Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lrzsz: fix clang -Werror on darwin #268833

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Conversation

emilytrau
Copy link
Member

Regression from darwin stdenv bump (#234710). This is a dependency of minicom.

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Regression from darwin stdenv bump (NixOS#234710)
@emilytrau emilytrau added 6.topic: darwin Running or building packages on Darwin 0.kind: build failure A package fails to build labels Nov 20, 2023
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 21, 2023
@emilytrau emilytrau merged commit 067cd41 into NixOS:master Nov 21, 2023
14 checks passed
@emilytrau emilytrau deleted the lrzsz-darwin branch November 21, 2023 04:32
Copy link
Contributor

github-actions bot commented Dec 3, 2023

Backport failed for release-23.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-23.11
git worktree add -d .worktree/backport-268833-to-release-23.11 origin/release-23.11
cd .worktree/backport-268833-to-release-23.11
git switch --create backport-268833-to-release-23.11
git cherry-pick -x a91d4613a64c84819c0f533383adf4a938958d52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: build failure A package fails to build 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants