Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postgresql16Packages.pg_safeupdate: 1.4 -> 1.5 #269755

Merged
merged 1 commit into from
Nov 25, 2023
Merged

postgresql16Packages.pg_safeupdate: 1.4 -> 1.5 #269755

merged 1 commit into from
Nov 25, 2023

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Nov 25, 2023

Diff: eradman/pg-safeupdate@1.4...1.5

Changelog: https://github.com/eradman/pg-safeupdate/raw/1.5/NEWS

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Priorities

Add a 👍 reaction to pull requests you find important.

@marsam marsam merged commit dc58473 into NixOS:master Nov 25, 2023
24 checks passed
@marsam marsam deleted the update-pg_safeupdate branch November 25, 2023 03:41
@wolfgangwalther wolfgangwalther mentioned this pull request Mar 26, 2024
Merged
13 tasks
wolfgangwalther added a commit to wolfgangwalther/nixpkgs that referenced this pull request Mar 31, 2024
@wolfgangwalther
postgresql{12,13}Packages.pg_safeupdate: 1.5 -> 1.4
5e0eeb3 
pg_safeupdate was updated to 1.5 in NixOS#269755. v1.5 is not compatible with
PostgreSQL 12 and 13 anymore, so those were marked as broken.

However, this blocks anyone using PostgreSQL 12 or 13 with pg_safeupdate
from updating nixpkgs.

Instead, the old version should have been kept for PG 12 and 13.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@marsam