Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

olive-editor: fix build by pinning openimageio to 2.4.15.0 #271909

Merged
merged 1 commit into from
Dec 5, 2023
Merged

olive-editor: fix build by pinning openimageio to 2.4.15.0 #271909

merged 1 commit into from
Dec 5, 2023

Conversation

pbsds
Copy link
Member

@pbsds pbsds commented Dec 3, 2023 •
edited
Loading

Description of changes

Fixes breakage introduced in in #260603

I opted to pin, due to low upstream activity

CC maintainer @balsoft
CC @tobim due to olive-editor/olive#2294

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@pbsds pbsds marked this pull request as ready for review December 3, 2023 19:08
@ofborg ofborg bot requested a review from balsoft December 3, 2023 22:11
@puetzk puetzk mentioned this pull request Dec 4, 2023
Merged
13 tasks
SuperSandro2000
SuperSandro2000 approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this is not just a version cosntraint, it is totally fine to downgrade

pkgs/applications/video/olive-editor/default.nix Show resolved Hide resolved
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 4, 2023
@pbsds pbsds force-pushed the fix-olive-editor-1701629752 branch from c4876a0 to 931de38 Compare December 4, 2023 02:16
@delroth delroth removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 4, 2023
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 4, 2023
@pbsds pbsds merged commit 0b7b181 into NixOS:master Dec 5, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@balsoft balsoft Awaiting requested review from balsoft

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pbsds @SuperSandro2000 @delroth