-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Python no runtime deps at build time #272179
Closed
adisbladis
wants to merge
5
commits into
NixOS:master
from
adisbladis:python-no-runtime-deps-at-build
Closed
WIP: Python no runtime deps at build time #272179
adisbladis
wants to merge
5
commits into
NixOS:master
from
adisbladis:python-no-runtime-deps-at-build
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adisbladis
requested review from
FRidh,
jonringer and
mweinelt
as code owners
December 5, 2023 02:21
github-actions
bot
added
6.topic: python
8.has: documentation
This PR adds or changes documentation
labels
Dec 5, 2023
3 tasks
3 tasks
wegank
added
the
2.status: merge conflict
This PR has merge conflicts with the target branch
label
Mar 20, 2024
wegank
added
the
2.status: stale
https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md
label
Jul 4, 2024
adisbladis
force-pushed
the
python-no-runtime-deps-at-build
branch
from
July 18, 2024 00:35
dcceee3
to
0050637
Compare
stale
bot
removed
the
2.status: stale
https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md
label
Jul 18, 2024
github-actions
bot
removed
the
8.has: documentation
This PR adds or changes documentation
label
Jul 18, 2024
adisbladis
force-pushed
the
python-no-runtime-deps-at-build
branch
from
July 18, 2024 00:59
0050637
to
67d7d6b
Compare
ofborg
bot
removed
the
2.status: merge conflict
This PR has merge conflicts with the target branch
label
Jul 18, 2024
adisbladis
force-pushed
the
python-no-runtime-deps-at-build
branch
2 times, most recently
from
July 18, 2024 03:03
196a0c1
to
6bb412c
Compare
adisbladis
force-pushed
the
python-no-runtime-deps-at-build
branch
from
July 18, 2024 05:05
6bb412c
to
07a19f7
Compare
13 tasks
13 tasks
wegank
added
the
2.status: merge conflict
This PR has merge conflicts with the target branch
label
Sep 10, 2024
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Removes dependency propagation from
buildPythonPackage
when a runtime dependency is passed viadependencies
.Please don't actually review the code yet. This a a very WIP, very draft PoC & should be considered a demo for #272178.
This also includes the commits from #271597.
Only the commits prefixed with WIP: are a part of this.
python3Packages.foo
Depending on a Python package like this will break:
You will instead need to:
This is because dependencies are no longer build-time propagated, so the full dependency graph calculation needs to happen in the Nix evaluator.
python3Packages.buildPythonPackage
vspython3Packages.buildPythonApplication
buildPythonPackage
is for building a Python package without dependency propagationbuildPythonApplication
is for building application bundles. This internally callsbuildPythonPackage
, and also creates a wrapper derivation that takes care of callingrequiredPythonModules
.All Python applications which has runnable binaries now needs to either be:
buildPythonApplication
toPythonApplication
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.