tests.trivial-builders.references: provide passthru attributes and override interface on non-Linux platforms #273183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
10.rebuild-darwin: 0
ShamrockLee
force-pushed
the
test-references-shellcheck-fix
branch
from
8863dc9
to
160258a
Compare
ShamrockLee
changed the title
ShamrockLee
changed the title
ShamrockLee
force-pushed
the
test-references-shellcheck-fix
branch
from
160258a
to
1c4c1d4
Compare
13 tasks
ShamrockLee
force-pushed
the
test-references-shellcheck-fix
branch
from
1c4c1d4
to
b546bb0
Compare
ShamrockLee
changed the title
Forward override interface and essential passthru attributes of `tests.trivial-builders.references` to non-Linux platforms. Enable `pkgs`-wide `samples` overriding via the override interface of `tests.trivial-builders.references` in Nixpkgs overlays.
ShamrockLee
force-pushed
the
test-references-shellcheck-fix
branch
from
b546bb0
to
507db5e
Compare
ofborg
bot
added
10.rebuild-linux: 0
13 tasks
There was a problem hiding this comment.
I'd rather suggest to keep static attribute names, but set meta.platforms so that the attributes aren't evaluated outside linux
There was a problem hiding this comment.
Unfortunately, the NixOS test modules do not provide an option to specify/expose meta.platforms, nor does the result derivation come with overrideAttrs.
There was a problem hiding this comment.
Interesting
nix-repl> :lf github:ShamrockLee/nixpkgs/test-references-shellcheck-fix
nix-repl> legacyPackages.x86_64-linux.tests.trivial-builders.references.meta
{ broken = false; maintainers = [ ... ]; timeout = 3600; }
nix-repl> legacyPackages.x86_64-linux.tests.trivial-builders.references.override<TAB>
legacyPackages.x86_64-linux.tests.trivial-builders.references.override
legacyPackages.x86_64-linux.tests.trivial-builders.references.overrideDerivation
There was a problem hiding this comment.
Are you sure you need meta.platforms? If so, it can be added in nixos/lib/testing/meta.nix, or we could give that a freeformType.
- Fixing the overriding situation here: nixos.runTest: Add extend, overrideTestDerivation #299542
13 tasks
wegank
added
the
2.status: merge conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
NixOS VM Tests are not supported outside Linux so far, and we leave tests.trivial-builders.references = { } for non-Linux systems to please the CI.
If applied, non-Linux users will be able to run
testScriptBinand accesspassthruattributes and override interface oftest.trivial-builders.referencesthe way Linux users do.Status: waiting for #178717. It brings several renames and one extra test cases that depends on
samples.Cc: @roberth
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.