-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cargo-typify: init at 0.0.14 #273252
Merged
matthiasbeyer
merged 2 commits into
NixOS:master
from
integrated-reasoning:cargo-typify
Dec 26, 2023
Merged
cargo-typify: init at 0.0.14 #273252
matthiasbeyer
merged 2 commits into
NixOS:master
from
integrated-reasoning:cargo-typify
Dec 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NixOSInfra
added
the
12. first-time contribution
This PR is the author's first one; please be gentle!
label
Dec 10, 2023
Result of 1 package built:
|
david-r-cox
force-pushed
the
cargo-typify
branch
from
December 10, 2023 03:44
3bb5a5b
to
343008e
Compare
Result of 1 package built:
|
ofborg
bot
added
8.has: package (new)
This PR adds a new package
11.by: package-maintainer
This PR was created by the maintainer of the package it changes
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
10.rebuild-linux: 1
labels
Dec 10, 2023
wegank
reviewed
Dec 10, 2023
wegank
reviewed
Dec 10, 2023
david-r-cox
force-pushed
the
cargo-typify
branch
from
December 10, 2023 22:50
343008e
to
0112614
Compare
Result of 1 package built:
|
eclairevoyant
suggested changes
Dec 11, 2023
Thanks for the contribution! Some nits above. |
david-r-cox
force-pushed
the
cargo-typify
branch
from
December 11, 2023 23:01
0112614
to
2562649
Compare
Thanks for the feedback @eclairevoyant! TIL about |
Result of 1 package built:
|
matthiasbeyer
approved these changes
Dec 26, 2023
Result of 1 package built:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
8.has: package (new)
This PR adds a new package
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
10.rebuild-linux: 1
11.by: package-maintainer
This PR was created by the maintainer of the package it changes
12. first-time contribution
This PR is the author's first one; please be gentle!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.