cgproxy, nixos/cgproxy: init at 0.20 #273492
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
oluceps
added
8.has: package (new)
ofborg
bot
added
11.by: package-maintainer
| enable_ipv6 = enable_ipv4 > enable_dns > enable_tcp = enable_udp | ||
| command cgproxy and cgnoproxy always have highest priority | ||
|
|
||
| Note: cgroup in configuration need to be exist, otherwise ignored |
There was a problem hiding this comment.
Could we assert this?
Nope, this is from upstream README and seems related to the cgroup at runtime, nix cannot handle this. I think this note may be unnecessary.
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
fsnkty
reviewed
Feb 7, 2024
| @@ -0,0 +1,110 @@ | |||
| { config, lib, pkgs, ... }: | |||
|
|
|||
| with lib; | |||
There was a problem hiding this comment.
to address #208242 for this module, uses of with such as this should be avoided.
consider inherits where you find yourself using lib.foo excessively.
|
|
||
| options = { | ||
| services.cgproxy = { | ||
| enable = mkEnableOption (lib.mdDoc "cgproxy"); |
|
There may be some env issues in scripts. Mark as a draft until I have time to handle this. https://github.com/springzfx/cgproxy/blob/master/cgroup-tproxy.sh |
|
Link #287770 |
wegank
added
the
2.status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add https://github.com/springzfx/cgproxy
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.