llm-ls: fix darwin build (in progress) #274012
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #273596, related to #19098.
Currently, this change builds successfully for 933d7dc (my nixpkgs/nixos-23.11) and 06b4b4e (my nixpkgs unstable), but it does not build when branched from 102c342. I'd love some help debugging the reason. The log from the build failure is here. @jfvillablanca is the maintainer listed for this package and asked me to shepherd this because they do not have access to an
aarch64-darwin
machine.Description of changes
Added in a flag to not use Link-Time Optimization as per #19098. (The particular change is shameless lifted from 3ade63b87b4a5265b8abd895a0073125b9a7db16, thanks @michaelhthomas)
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.