Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fzf-make: 0.9.0 -> 0.11.0 #274362

Merged
merged 1 commit into from
Dec 15, 2023
Merged

fzf-make: 0.9.0 -> 0.11.0 #274362

merged 1 commit into from
Dec 15, 2023

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/kyu08/fzf-make/releases.

meta.description for fzf-make is: Fuzzy finder for Makefile

meta.homepage for fzf-make is: https://github.com/kyu08/fzf-make

meta.changelog for fzf-make is: https://github.com/kyu08/fzf-make/releases/tag/v0.11.0

Updates performed
  • Rust version update
To inspect upstream changes
Impact
Checks done (click to expand)
  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 0.11.0 with grep in /nix/store/89ms30vxnlcr6g0f7nmcfjcp813641ix-fzf-make-0.11.0
  • found 0.11.0 in filename of file in /nix/store/89ms30vxnlcr6g0f7nmcfjcp813641ix-fzf-make-0.11.0

Rebuild report (if merged into master) (click to expand)
1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
fzf-make
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/89ms30vxnlcr6g0f7nmcfjcp813641ix-fzf-make-0.11.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A fzf-make https://github.com/r-ryantm/nixpkgs/archive/7034e9bfc6bad15052b2a20e8b6b4a149d9a8788.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/7034e9bfc6bad15052b2a20e8b6b4a149d9a8788#fzf-make

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/89ms30vxnlcr6g0f7nmcfjcp813641ix-fzf-make-0.11.0
ls -la /nix/store/89ms30vxnlcr6g0f7nmcfjcp813641ix-fzf-make-0.11.0/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • fzf-make

Maintainer pings

cc @figsoda @Sigmanificient for testing.

Copy link
Member

@Sigmanificient Sigmanificient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

panic: Any { .. } when running :<

@Ma27
Copy link
Member

Ma27 commented Dec 15, 2023

panic: Any { .. } when running :<

Just played around with it as well. Do older versions work fine with Makefiles that are now causing issues?

Because I quickly realized that this doesn't work well with advanced makefiles.

@Sigmanificient
Copy link
Member

Sigmanificient commented Dec 15, 2023

This seems to be an issue with the Makefile being too complex to parse?
I opened an issue here

@kyu08
Copy link

kyu08 commented Dec 15, 2023

I'm sorry about fzf-make does not work fine on certain situation.

Because I quickly realized that this doesn't work well with advanced makefiles.

@Ma27
If you don't mind, could you provide actual makefiles? I want to find out the cause and fix it.


(EDIT)
Thanks to @Sigmanificient 's help, I found out a bug. It was because fzf-make can not interpret include directive includes variable like -include $(DEP).
Also, if file path that not exist is specified with include directive, fzf-make panics.
I will fix this bug and release new version in few days.

@Ma27 Ma27 marked this pull request as draft December 15, 2023 12:58
@Sigmanificient
Copy link
Member

I think this might be fixed in the next release, except from this, seems like it works as intended.

@Ma27 Ma27 marked this pull request as ready for review December 15, 2023 13:26
@Ma27
Copy link
Member

Ma27 commented Dec 15, 2023

Fair, sounded like it was a regression to me, but then we can merge this already.

@Ma27 Ma27 merged commit cc9a93a into NixOS:master Dec 15, 2023
26 checks passed
@kyu08
Copy link

kyu08 commented Dec 15, 2023

@Sigmanificient @Ma27

I released the v0.12.0 which fixes the bug!
Cloud you upgrade package if you have a chance please.

@r-ryantm r-ryantm deleted the auto-update/fzf-make branch December 16, 2023 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants