Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rstudio: 2023.09.0+463 -> 2023.12.0+369 #275649

Closed
wants to merge 8 commits into from

Conversation

b-rodrigues
Copy link
Contributor

@b-rodrigues b-rodrigues commented Dec 20, 2023

Description of changes

This is a draft PR because I tried upgrading to the latest version of RStudio, but there seems to be an issue with CMake. See next message with the error message.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@b-rodrigues
Copy link
Contributor Author

Trying to build now results in following message:

-- Configuring incomplete, errors occurred!
error: builder for '/nix/store/jn4im93rx67cp0z2yzgdr6swyy8f9vwb-RStudio-2023.12.0+369.drv' failed with exit code 1;
       last 10 log lines:
       > -- Looking for group_member
       > -- Looking for group_member - found
       > -- Performing Test HAVE_EXECINFO
       > -- Performing Test HAVE_EXECINFO - Success
       > -- Configured to build DESKTOP
       > -- Found LibR: /nix/store/m3lp6c2vgb6lvznfn8ichz8di4r51s8m-R-4.3.2/lib/R
       > -- Found R: /nix/store/m3lp6c2vgb6lvznfn8ichz8di4r51s8m-R-4.3.2/lib/R
       > -- Found Qt: /nix/store/pq91ai5s5h7nn3l2pa9cbrniw1cszpvj-qmake-hook/bin/qmake
       > -- Packaging RStudio for
       > -- Configuring incomplete, errors occurred!
       For full logs, run 'nix log /nix/store/jn4im93rx67cp0z2yzgdr6swyy8f9vwb-RStudio-2023.12.0+369.drv'.
error: 1 dependencies of derivation '/nix/store/4ldy5gahsal3azl4z8gnyibdqdszzav6-nix-shell.drv' failed to build

This is the configuration steps that fails:

-- Looking for getpeereid - not found

no idea what this is though

@philipp-baumann
Copy link
Contributor

getpeereid

could this maybe be related to this? rstudio/rstudio#9600

@b-rodrigues
Copy link
Contributor Author

Perhaps, but according to that thread it was an issue of gcc being too old: I don’t think we have this problem here?

@philipp-baumann
Copy link
Contributor

Result of nixpkgs-review pr 275649 run on aarch64-darwin 1

$ /nix/store/fgp1c16hly3960pnw765ac11a1p0a39r-nix-2.18.1/bin/nix-shell /Users/philipp/.cache/nixpkgs-review/pr-275649/shell.nix --nix-path nixpkgs=/Users/philipp/.cache/nixpkgs-review/pr-275649/nixpkgs nixpkgs-overlays=/tmp/tmpsh0gpt9r

@philipp-baumann
Copy link
Contributor

Perhaps, but according to that thread it was an issue of gcc being too old: I don’t think we have this problem here?

it is a bit strange though yes. Your current PR commit compiles on aarch64-darwin, so I wonder whether some specific gcc related imports in nativeBuildInputs could resolve on linux platforms. A wild guess because I am quite a nix beginner.

@b-rodrigues
Copy link
Contributor Author

I've updated the source to use the latest rsconnect, and still get the same error message:

Looking for strtod_l - not found
Looking for getpeereid - not found

@ofborg ofborg bot requested a review from ciil December 20, 2023 22:29
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 20, 2023
@b-rodrigues
Copy link
Contributor Author

Closing this as @Kupac got it working over here

#289393

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants