swig4: 4.0.2 -> 4.2.1 #277049
Merged
swig4: 4.0.2 -> 4.2.1 #277049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3220 |
quantenzitrone
suggested changes
Jan 6, 2024
|
Result of 30 packages failed to build:
91 packages built:
non-empty logs https://gist.github.com/pbsds/b5a614c1cd6f8431899b837a2b94d704 |
wegank
force-pushed
the
update-swig4
branch
2 times, most recently
from
79e5051
to
9728175
Compare
|
Thanks @wegank, for the updates on this PR. What's a good strategy to move forward with this? 30 failed packages are a bit much for me to try and fix, especially as I can only build on my local workstation. Should I look out for updates on the failed packages? Contact those maintainers? Any ideas and suggestions are most welcome. |
|
I think it's necessary to open separate PRs to fix the packages before merging this (I've made 14 for the bump to exiv2 0.28, for example). But it would indeed be a good idea to ping the maintainers first to see if they can fix them. |
|
@pbsds would you be willing to do another |
|
Thanks for the recommendation @wegank, I'll work through the build failures and will open Issues or PRs and ask the package maintainers for help. |
|
Result of 13 packages marked as broken and skipped:
25 packages failed to build:
75 packages built:
Hydra EDIT: i built the
|
13 tasks
|
With the availability of the 24.05 release and this PRs branch having rebased on the current |
|
Result of 38 packages marked as broken and skipped:
22 packages failed to build:
24 packages built:
|
|
Find below a few findings, thoughts, questions related to the build failures posted above:
|
|
I wouldn't worry about packages that are already broken on hydra, like kicad, txtai and pytorch-metric-learning. You can check so by inserting the attribute path into urls like https://hydra.nixos.org/job/nixos/trunk-combined/nixpkgs.kicad-unstable.x86_64-linux For new breakages you need to determine whether the failure is due to flakyness/impurity or due to the change in swig4 I'm running nixpkgs-review on x86_64-linux now |
I'm sure it is non-optional now. In particular,
Yes, but I think my #272425 is no longer working from a certain date this year, I'll try to bump the package again in that PR this weekend. |
|
I wasn't aware about the or-tools update in #272425, happy to help test on |
|
Result of 38 packages marked as broken and skipped:
22 packages failed to build:
24 packages built:
|
|
Result of 9 packages failed to build:
55 packages built:
|
|
Result of 8 packages marked as broken and skipped:
12 packages built:
|
|
Mind having another look at this, @siraben, @quantenzitrone, @wegank, @SomeoneSerge? Checking the failed linux builds the following packages also fail on a recent commit (d3cb976) on master and are likely unrelated to the changes proposed in this PR:
The build failure of faiss is known (see facebookresearch/faiss#3239), related to the changes in this PR, and addressed by 3cdf3ed also included in this PR. The other failures are very likely failures related to the faiss build-failure as they seem to have faiss as a dependency. |
|
Result of 2 packages failed to build:
62 packages built:
|
Co-authored-by: quantenzitrone <74491719+quantenzitrone@users.noreply.github.com>
|
Result of 2 packages marked as broken and skipped:
18 packages failed to build:
110 packages built:
|
|
only new failure is described in #287880, LGTM |
|
Thank you for your contribution @afh, this one took a while to get merged |
|
Thanks @pbsds and everyone involved for your feedback and helping getting this merged, very much appreciated!! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
👉 NOTA BENE: This PR depends on the relaxed gpytorch version requirement for botorch changes from #328732 in order to successfully run ``nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
onaarch64-darwin`.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.