python312Packages.torch: unroll recursive git retrieval #277789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeuner
force-pushed
the
pytorch-unroll-2-1-2
branch
from
510deef to
bf48e15
Compare
wegank
added
the
2.status: merge conflict
zeuner
force-pushed
the
pytorch-unroll-2-1-2
branch
2 times, most recently
from
a639010 to
1495e3a
Compare
ofborg
bot
removed
the
2.status: merge conflict
zeuner
changed the title
FliegendeWurst
added
the
2.status: merge conflict
FliegendeWurst
requested changes
Oct 31, 2024
zeuner
force-pushed
the
pytorch-unroll-2-1-2
branch
from
1495e3a to
ce4850e
Compare
Yes... not too surprisingly, there has been another upstream version merged. |
ofborg
bot
removed
the
2.status: merge conflict
FliegendeWurst
requested changes
Nov 1, 2024
| }; | ||
| # the following expression has been generated using | ||
| # https://codeberg.org/gm6k/git-unroll | ||
| src = |
There was a problem hiding this comment.
Given the size of this expression, I think it would be best to outsource it to a new file src.nix or similar.
There was a problem hiding this comment.
Good point. I'm now also exposing an update script through passthru.unroll-src.
zeuner
force-pushed
the
pytorch-unroll-2-1-2
branch
from
ce4850e to
db4a2a8
Compare
again... |
zeuner
force-pushed
the
pytorch-unroll-2-1-2
branch
from
db4a2a8 to
c243f04
Compare
FliegendeWurst
approved these changes
Nov 4, 2024
| @@ -219,6 +223,27 @@ let | |||
| "Rocm support is currently broken because `rocmPackages.hipblaslt` is unpackaged. (2024-06-09)" = | |||
| rocmSupport; | |||
| }; | |||
|
|
|||
| git-unroll = fetchFromGitea { | |||
There was a problem hiding this comment.
This could be its own package, since it is also useful elsewhere. Can be done in another PR eventually
wegank
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR replaces the recursive fetch of the package source by non-recursive fetches of the corresponding (sub-)modules. This allows using the more efficient specialized fetchers, is more robust in presence of network issues, and allows for reusing sub-modules if they don't change between updates. Furthermore, it can be a starting point for reducing code duplication caused by the sub-modules.
Fixes #276585
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.