Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wireplumber: 0.4.17 -> 0.5.0 #278760

Merged
merged 1 commit into from
Mar 18, 2024
Merged

wireplumber: 0.4.17 -> 0.5.0 #278760

merged 1 commit into from
Mar 18, 2024

Conversation

K900
Copy link
Contributor

@K900 K900 commented Jan 4, 2024

Description of changes

0.5 beta, do not merge.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 4, 2024
@K900 K900 force-pushed the wireplumber-0.5 branch from 960d6e0 to bcf86a4 Compare January 4, 2024 20:08
@K900 K900 requested a review from infinisil January 4, 2024 20:11
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 4, 2024
@infinisil
Copy link
Member

This breaks my system-wide setup, there's no audio output to select. Nothing special in the logs.

@K900 K900 changed the title wireplumber: 0.4.17 -> 0.4.81 wireplumber: 0.4.17 -> 0.4.82 Feb 14, 2024
@K900 K900 force-pushed the wireplumber-0.5 branch 2 times, most recently from 7e50e00 to 22b554c Compare March 4, 2024 18:17
@K900 K900 changed the title wireplumber: 0.4.17 -> 0.4.82 wireplumber: 0.4.17 -> 0.4.90 Mar 4, 2024
@K900 K900 force-pushed the wireplumber-0.5 branch from 22b554c to bb227af Compare March 4, 2024 19:07
@K900
Copy link
Contributor Author

K900 commented Mar 4, 2024

System-wide should be fixed now.

philiptaron added a commit to philiptaron/flock.nix that referenced this pull request Mar 5, 2024
@philiptaron
Copy link
Contributor

I tested this out (philiptaron/flock.nix@c8c54b6 and following).

Existing regression / experience: gdm user cannot play sound through clicking on the speaker icon in the right-hand panel.

  1. ✅ Non-system-wide has sound as my user.
  2. ✅ System-wide has sound as my user, as I had my user in the pipewire group to start with.
  3. 🤔 Until I added the gdm user to the pipewire group, the sound icon in gdm didn't show up. Makes sense.
  4. 😐 After I added the gdm user to the pipewire group, the existing regression occurred and no sound came out.

Also, GNOME shell cored in libmutter. I don't think this is related based on the callstack.

Using host libthread_db library "/nix/store/8mc30d49ghc8m5z96yz39srlhg5s9sjj-glibc-2.38-44/lib/libthread_db.so.1".
Core was generated by `/nix/store/m1li0lj6icz2y9aqznh2pz180y8jxhcz-gnome-shell-45.4/bin/gnome-shell'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x00007fd2a52c0829 in meta_get_stage_for_display () from /nix/store/r6swshz267kk3c2hydyq3pi6hszsjhlj-mutter-45.4/lib/libmutter-13.so.0
[Current thread is 1 (Thread 0x7fd29f6cae00 (LWP 1698))]
(gdb) bt
#0  0x00007fd2a52c0829 in meta_get_stage_for_display () from /nix/store/r6swshz267kk3c2hydyq3pi6hszsjhlj-mutter-45.4/lib/libmutter-13.so.0
#1  0x00007fd2a52c0aea in meta_stage_is_focused () from /nix/store/r6swshz267kk3c2hydyq3pi6hszsjhlj-mutter-45.4/lib/libmutter-13.so.0
#2  0x00007fd2a5a2922d in focus_window_changed (display=<optimized out>, param=<optimized out>, user_data=0x15a3b10) at ../src/shell-global.c:790
#3  0x00007fd2a5e0f468 in g_closure_invoke (closure=0x1e1cc10, return_value=0x0, n_param_values=2, param_values=0x7ffc7a4fc870, invocation_hint=0x7ffc7a4fc7c0) at ../gobject/gclosure.c:832
#4  0x00007fd2a5e2226c in signal_emit_unlocked_R (node=node@entry=0x7ffc7a4fc940, detail=detail@entry=934, instance=instance@entry=0x1dd92e0, emission_return=emission_return@entry=0x0,
    instance_and_params=instance_and_params@entry=0x7ffc7a4fc870) at ../gobject/gsignal.c:3980
#5  0x00007fd2a5e23c01 in signal_emit_valist_unlocked (instance=instance@entry=0x1dd92e0, signal_id=signal_id@entry=1, detail=detail@entry=934, var_args=var_args@entry=0x7ffc7a4fcaa0) at ../gobject/gsignal.c:3612
#6  0x00007fd2a5e29962 in g_signal_emit_valist (instance=0x1dd92e0, signal_id=1, detail=934, var_args=0x7ffc7a4fcaa0) at ../gobject/gsignal.c:3355
#7  0x00007fd2a5e29a0f in g_signal_emit (instance=instance@entry=0x1dd92e0, signal_id=<optimized out>, detail=<optimized out>) at ../gobject/gsignal.c:3675
#8  0x00007fd2a5e133c4 in g_object_dispatch_properties_changed (object=0x1dd92e0, n_pspecs=<optimized out>, pspecs=<optimized out>) at ../gobject/gobject.c:1427
#9  0x00007fd2a5e1626e in g_object_notify_by_spec_internal (pspec=<optimized out>, object=0x1dd92e0) at ../gobject/gobject.c:1551
#10 g_object_notify (object=0x1dd92e0, property_name=<optimized out>) at ../gobject/gobject.c:1601
#11 0x00007fd2a52dff99 in meta_display_set_input_focus () from /nix/store/r6swshz267kk3c2hydyq3pi6hszsjhlj-mutter-45.4/lib/libmutter-13.so.0
#12 0x00007fd2a5302bda in meta_window_unmanage () from /nix/store/r6swshz267kk3c2hydyq3pi6hszsjhlj-mutter-45.4/lib/libmutter-13.so.0
#13 0x00007fd2a52df5e0 in meta_display_unmanage_windows () from /nix/store/r6swshz267kk3c2hydyq3pi6hszsjhlj-mutter-45.4/lib/libmutter-13.so.0
#14 0x00007fd2a52e0839 in meta_display_close () from /nix/store/r6swshz267kk3c2hydyq3pi6hszsjhlj-mutter-45.4/lib/libmutter-13.so.0
#15 0x00007fd2a52eb716 in meta_context_dispose () from /nix/store/r6swshz267kk3c2hydyq3pi6hszsjhlj-mutter-45.4/lib/libmutter-13.so.0
#16 0x00007fd2a5e15f5a in g_object_run_dispose (object=0x158f9d0) at ../gobject/gobject.c:1447
#17 0x00007fd2a52ec1d9 in meta_context_destroy () from /nix/store/r6swshz267kk3c2hydyq3pi6hszsjhlj-mutter-45.4/lib/libmutter-13.so.0
#18 0x0000000000403a9b in main (argc=<optimized out>, argv=<optimized out>) at ../src/main.c:739

I don't know if this is related. I also note that GNOME shell has a spinning/busy icon when hovering over the right-hand panel for longer with this PR applied when I first log in.

I don't see anything in journalctl -b --user that's relevant.

For the wireplumber service, here's the logs (I think nominal.) Maybe I need to figure out the deal with org.freedesktop.impl.portal.PermissionStore; pretty sure that's just something I haven't wired up yet.

Mar 05 07:40:49 zebul systemd[1]: wireplumber.service: Installed new job wireplumber.service/start as 842
Mar 05 07:40:49 zebul systemd[1]: wireplumber.service: Will spawn child (service_enter_start): /nix/store/n3qyh3j24c07zxs8bbj72iqwz42pwvjf-wireplumber-0.4.90/bin/wireplumber
Mar 05 07:40:49 zebul systemd[1]: wireplumber.service: Passing 0 fds to service
Mar 05 07:40:49 zebul systemd[1]: wireplumber.service: About to execute: /nix/store/n3qyh3j24c07zxs8bbj72iqwz42pwvjf-wireplumber-0.4.90/bin/wireplumber
Mar 05 07:40:49 zebul systemd[1]: wireplumber.service: Forked /nix/store/n3qyh3j24c07zxs8bbj72iqwz42pwvjf-wireplumber-0.4.90/bin/wireplumber as 1328
Mar 05 07:40:49 zebul systemd[1]: wireplumber.service: Changed dead -> running
Mar 05 07:40:49 zebul systemd[1]: wireplumber.service: Job 842 wireplumber.service/start finished, result=done
Mar 05 07:40:49 zebul systemd[1]: Started Multimedia Service Session Manager.
Mar 05 07:40:49 zebul systemd[1]: wireplumber.service: User lookup succeeded: uid=323 gid=323
Mar 05 07:40:49 zebul (eplumber)[1328]: Found cgroup2 on /sys/fs/cgroup/, full unified hierarchy
Mar 05 07:40:49 zebul (eplumber)[1328]: Found cgroup2 on /sys/fs/cgroup/, full unified hierarchy
Mar 05 07:40:49 zebul (eplumber)[1328]: wireplumber.service: Enabled MemoryDenyWriteExecute= with PR_SET_MDWE
Mar 05 07:40:49 zebul (eplumber)[1328]: 0x194d120: no modules loaded from context.modules
Mar 05 07:40:49 zebul (eplumber)[1328]: <WpCore:0x194c6c0> skipping component 'monitor.alsa.reserve-device [virtual]' because some of its dependencies were not loaded
Mar 05 07:40:50 zebul wireplumber[1328]: [0:00:08.289223331] [1328]  INFO IPAManager ipa_manager.cpp:143 libcamera is not installed. Adding '/nix/store/src/ipa' to the IPA search path
Mar 05 07:40:50 zebul wireplumber[1328]: [0:00:08.290104135] [1328]  INFO Camera camera_manager.cpp:284 libcamera v0.2.0
Mar 05 07:40:57 zebul wireplumber[1328]: [0:00:16.057850658] [1372]  WARN V4L2 v4l2_pixelformat.cpp:328 Unsupported V4L2 pixel format H264
Mar 05 07:40:59 zebul wireplumber[1328]: <WpPortalPermissionStorePlugin:0x19f8bf0> Failed to call Lookup: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.impl.portal.PermissionStore was not provided by any .service files

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 8, 2024
@K900 K900 force-pushed the wireplumber-0.5 branch from bb227af to 823897d Compare March 18, 2024 15:58
@K900 K900 changed the title wireplumber: 0.4.17 -> 0.4.90 wireplumber: 0.4.17 -> 0.5.0 Mar 18, 2024
@K900 K900 marked this pull request as ready for review March 18, 2024 15:59
@K900 K900 merged commit 7cf4cfa into NixOS:master Mar 18, 2024
8 of 9 checks passed
@deifactor
Copy link
Contributor

Note that this also changes how configuration works, moving away from lua and towards SPA-JSON.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants