-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
polylux2pdfpc: init at 0.3.1 #280525
polylux2pdfpc: init at 0.3.1 #280525
Conversation
in | ||
rustPlatform.buildRustPackage rec { | ||
pname = "polylux2pdfpc"; | ||
version = "0.3.1"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be 0.1.0? See https://github.com/andreasKroepelin/polylux/blob/main/pdfpc-extractor/Cargo.toml#L5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't sure what to put as the version, since the author doesn't seem to be properly releasing tags for this "sub package". I'm afraid that the code might change in the future without the version changing.
I settled on 0.3.1 because that's what the AUR package is using: https://aur.archlinux.org/packages/polylux2pdfpc (and this tool was only introduced in version 0.3.0 of the parent package: https://polylux.dev/book/changelog.html)
If you think 0.1.0 is preferable (or unstable-2023-08-25
, the date of the last commit on that folder), I have no objections to changing it to that.
Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts?
Open an upstream issue.
240a616
to
1cdf200
Compare
1cdf200
to
a5f0fb4
Compare
a5f0fb4
to
5c36cea
Compare
5c36cea
to
c0c65d9
Compare
c0c65d9
to
c04a50b
Compare
c04a50b
to
75731aa
Compare
Do you think you could make it work on |
@drupol Hm... I'm not sure if I know how to do that. What do I need to add to the derivation? |
I have the feeling that it's an unrelated issue. Going to merge it as it is.
|
Thanks for making the PR, it is now merged. I believe we won't have to use it much since there's a PR in Polylux to extract those data without using any external tool. See: andreasKroepelin/polylux#123 |
Description of changes
Small tool to convert metadata in PDF presentations made in typst with polylux to a format pdfpc can understand.
https://github.com/andreasKroepelin/polylux
Tool is located under the
pdfpc-extrator
directory.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.