Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polylux2pdfpc: init at 0.3.1 #280525

Merged
merged 2 commits into from
Jan 20, 2024
Merged

polylux2pdfpc: init at 0.3.1 #280525

merged 2 commits into from
Jan 20, 2024

Conversation

diogotcorreia
Copy link
Member

Description of changes

Small tool to convert metadata in PDF presentations made in typst with polylux to a format pdfpc can understand.

https://github.com/andreasKroepelin/polylux

Tool is located under the pdfpc-extrator directory.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jan 12, 2024
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
in
rustPlatform.buildRustPackage rec {
pname = "polylux2pdfpc";
version = "0.3.1";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure what to put as the version, since the author doesn't seem to be properly releasing tags for this "sub package". I'm afraid that the code might change in the future without the version changing.

I settled on 0.3.1 because that's what the AUR package is using: https://aur.archlinux.org/packages/polylux2pdfpc (and this tool was only introduced in version 0.3.0 of the parent package: https://polylux.dev/book/changelog.html)

If you think 0.1.0 is preferable (or unstable-2023-08-25, the date of the last commit on that folder), I have no objections to changing it to that.

Thoughts?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts?

Open an upstream issue.

pkgs/by-name/po/polylux2pdfpc/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/po/polylux2pdfpc/package.nix Show resolved Hide resolved
pkgs/by-name/po/polylux2pdfpc/package.nix Outdated Show resolved Hide resolved
@drupol
Copy link
Contributor

drupol commented Jan 20, 2024

Do you think you could make it work on aarch64-darwin as well ?

@diogotcorreia
Copy link
Member Author

diogotcorreia commented Jan 20, 2024

@drupol Hm... I'm not sure if I know how to do that. What do I need to add to the derivation?
And is it possible to test if it works from a linux (x86_64) machine?

@drupol
Copy link
Contributor

drupol commented Jan 20, 2024

I have the feeling that it's an unrelated issue. Going to merge it as it is.

          449|   */
          450|   functionArgs = f:
             |                  ^
          451|     if f ? __functor

       error: getting status of '/private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/macstadium-m1-44911104/pkgs/by-name/po/polylux2pdfpc': No such file or directory

Cannot nix-instantiate `polylux2pdfpc.passthru.tests' because:
error: attribute 'polylux2pdfpc' in selection path 'polylux2pdfpc.passthru.tests' not found

@drupol drupol merged commit b914a99 into NixOS:master Jan 20, 2024
24 checks passed
@drupol
Copy link
Contributor

drupol commented Jan 20, 2024

Thanks for making the PR, it is now merged. I believe we won't have to use it much since there's a PR in Polylux to extract those data without using any external tool. See: andreasKroepelin/polylux#123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants