Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sweet-folders: init at unstable-2023-03-18 #280975

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Conversation

D3vil0p3r
Copy link
Member

@D3vil0p3r D3vil0p3r commented Jan 14, 2024

Description of changes

sweet-folders: init at unstable-2023-03-18

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@D3vil0p3r D3vil0p3r marked this pull request as ready for review January 14, 2024 17:14
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3274

Copy link
Member

@h7x4 h7x4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments

pkgs/data/icons/sweet-folders/default.nix Outdated Show resolved Hide resolved
pkgs/data/icons/sweet-folders/default.nix Outdated Show resolved Hide resolved
pkgs/data/icons/sweet-folders/default.nix Outdated Show resolved Hide resolved
@h7x4
Copy link
Member

h7x4 commented Jan 18, 2024

There are quite a few dead symlinks in the resulting package. Do you think it's an upstream problem?

Edit: found EliverLara/Sweet-folders#18. I'll merge the package as is

@h7x4 h7x4 merged commit 910e4db into NixOS:master Jan 18, 2024
26 of 29 checks passed
Copy link
Contributor

Successfully created backport PR for release-23.11:

@D3vil0p3r
Copy link
Member Author

There are quite a few dead symlinks in the resulting package. Do you think it's an upstream problem?

Edit: found EliverLara/Sweet-folders#18. I'll merge the package as is

Yes. I just commented on that my old post by reporting all broken symlinks.

@D3vil0p3r D3vil0p3r deleted the patch-4 branch January 18, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants