yosys: 0.36 -> 0.37

[Luflosi]

Description of changes

https://github.com/YosysHQ/yosys/releases/tag/yosys-0.37

The change to the patch is needed to fix this error on macOS:

+ clang -std=c++11 -O2 -o cxxrtl-test-value -I../../backends/cxxrtl/runtime test_value.cc -lstdc++
test_value.cc:1:10: fatal error: 'cassert' file not found
         ^~~~~~~~~
1 error generated.
make: *** [Makefile:891: test] Error 1

@hzeller this update breaks the package yosys-synlig.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[nbdd0121]

This broke yosys-synlig package.

EDIT: oh, I see this is already mentioned in description of changes. Is there a way to unbreak the package? If not, we should mark the package as broken.

[hzeller]

I'll have a look at synlig.

[Luflosi]

we should mark the package as broken

I probably should have done this but I didn't remember to do it. @nbdd0121 can you please create a PR for that?

Is there a way to unbreak the package?

Looking at the error message

/build/source/frontends/systemverilog/uhdm_common_frontend.cc: In member function 'virtual void systemverilog_plugin::UhdmCommonFrontend::execute(std::istream*&, std::string, std::vector<std::__cxx11::basic_string<char> >, Yosys::RTLIL::Design*)':
/build/source/frontends/systemverilog/uhdm_common_frontend.cc:154:21: error: too few arguments to function 'void Yosys::AST::process(Yosys::RTLIL::Design*, AstNode*, bool, bool, bool, bool, bool, bool, bool, bool, bool, bool, bool, bool, bool, bool, bool, bool, bool, bool, bool, bool, bool)'
  154 |         AST::process(design, current_ast, dump_ast1, dump_ast2, no_dump_ptr, dump_vlog1, dump_vlog2, dump_rtlil, false, false, false, false, false,
      |         ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  155 |                      false, false, false, false, false, dont_redefine, false, defer, default_nettype_wire);
      |                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /build/source/frontends/systemverilog/uhdm_common_frontend.h:20,
                 from /build/source/frontends/systemverilog/uhdm_common_frontend.cc:20:
/nix/store/7cpr7yd7hb2vvmbh3zlji4kqy5whnr6p-yosys-0.37/share/yosys/include/frontends/ast/ast.h:379:14: note: declared here
  379 |         void process(RTLIL::Design *design, AstNode *ast, bool nodisplay, bool dump_ast1, bool dump_ast2, bool no_dump_ptr, bool dump_vlog1, bool dump_vlog2, bool dump_rtlil, bool nolatches, bool nomeminit,
      |              ^~~~~~~
make: *** [Makefile:449: /build/source/build/release/systemverilog-plugin/uhdm_common_frontend.o] Error 1

It looks to me like there was a change to the API of Yosys and synlig probably needs to be updated.

@hzeller if you also think this is an upstream bug, can you please create a bug report?

[hzeller]

Yes, I will first check if it is an issue at head, then file an issue if needed. In any case I'll try to roll forward later today and see if I can fix things.

I think it good action for now to mark it as broken.

[hzeller]

Also broken at head. Filed chipsalliance/synlig#2299