Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p11-kit: add mingw32 support #281590

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

seanybaggins
Copy link
Contributor

Description of changes

Added mingw support for p11-kit. Relevant for #274274

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@seanybaggins
Copy link
Contributor Author

@ofborg build pkgs.pkgsCross.mingw32.p11-kit

@seanybaggins
Copy link
Contributor Author

@wegank could I snag a review?

@wegank
Copy link
Member

wegank commented Jan 17, 2024

LGTM.

I wonder why mesonEmulatorHook doesn't work, though. Probably Wine doesn't work without X server?

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 17, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 18, 2024
@wegank
Copy link
Member

wegank commented Jan 19, 2024

@ofborg build pkgsCross.mingw32.p11-kit

@wegank wegank merged commit e88ca79 into NixOS:master Jan 19, 2024
30 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants