Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openvpn: adding missing mainProgram value #281736

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Conversation

D3vil0p3r
Copy link
Member

Description of changes

Added missing mainProgram attribute to allow maintainers of packages depending on openvpn to use lib.getExe function.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@h7x4 h7x4 merged commit 9993f41 into NixOS:master Jan 18, 2024
23 of 25 checks passed
Copy link
Contributor

Successfully created backport PR for release-23.11:

Copy link
Member

@nevivurn nevivurn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM.

Also unrelated to this PR, but given that the reason for the generic {} stuff has been removed (added in #103019, removed in #212184), it can probably be cleaned up?

@h7x4
Copy link
Member

h7x4 commented Jan 18, 2024

I'm a bit perplexed that the commit had a timestamp in the future. Do you have some timezone issues with your git by any chance? @D3vil0p3r

@D3vil0p3r D3vil0p3r deleted the patch-13 branch January 18, 2024 12:56
@D3vil0p3r
Copy link
Member Author

I'm a bit perplexed that the commit had a timestamp in the future. Do you have some timezone issues with your git by any chance? @D3vil0p3r

Hey. I see the commit time right... 18 January 2024 11:20 AM (GMT+1). Which date do you see?

@h7x4
Copy link
Member

h7x4 commented Jan 18, 2024

If you look at the timeline in this PR, you can see that the commit has been pushed down past the merge and past nevivurns comment. During the time of merge, GitHub said something like committed in 5 minutes

Might be just a GitHub issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants