Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: drop LLVM8 #283551

Merged
3 commits merged into from Jan 30, 2024
Merged

treewide: drop LLVM8 #283551

3 commits merged into from Jan 30, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jan 24, 2024

Description of changes

drop llvmPackages_8. There are only two references in nixpkgs that need to be removed.

  • qv2ray uses clang_8 for darwin, darwin build marked as broken, just remove clang_8
  • windows.crossThreadsStdenv references llvmPackages_8 which was added in change 06c5e81. replaced with the llvmPackages alias not clear what is correct or how to test.
nixpkgs-review x64 linux

27 packages removed: clang (†8.0.1) clang (†8.0.1) clang-manpages (†8.0.1) clang-tools (†8.0.1) clang-wrapper (†8.0.1) clang-wrapper (†8.0.1) clang-wrapper (†8.0.1) clang-wrapper (†8.0.1) clang-wrapper (†8.0.1) clang-wrapper (†8.0.1) clang-wrapper (†8.0.1) compiler-rt-libc (†8.0.1) compiler-rt-libc (†8.0.1) libcxx (†8.0.1) libcxxabi (†8.0.1) libunwind (†8.0.1) lld (†8.0.1) lldb (†8.0.1) llvm (†8.0.1) llvm (†8.0.1) llvm (†8.0.1) llvm-binutils (†8.0.1) llvm-binutils-wrapper (†8.0.1) llvm-binutils-wrapper (†8.0.1) openmp (†8.0.1) stdenv-linux (†) stdenv-linux (†)

Nothing to be built.

Result of nixpkgs-review run on x86_64-linux 1

nixpkgs-review x64 darwin

27 packages removed: clang (†8.0.1) clang (†8.0.1) clang-manpages (†8.0.1) clang-tools (†8.0.1) clang-wrapper (†8.0.1) clang-wrapper (†8.0.1) clang-wrapper (†8.0.1) clang-wrapper (†8.0.1) clang-wrapper (†8.0.1) clang-wrapper (†8.0.1) clang-wrapper (†8.0.1) compiler-rt-libc (†8.0.1) compiler-rt-libc (†8.0.1) libcxx (†8.0.1) libcxxabi (†8.0.1) libunwind (†8.0.1) lld (†8.0.1) lldb (†8.0.1) llvm (†8.0.1) llvm (†8.0.1) llvm (†8.0.1) llvm-binutils (†8.0.1) llvm-binutils-wrapper (†8.0.1) llvm-binutils-wrapper (†8.0.1) openmp (†8.0.1) stdenv-darwin (†) stdenv-darwin (†)

Result of `nixpkgs-review` run on x86_64-darwin [1](https://github.com/Mic92/nixpkgs-review)

1 package marked as broken and skipped: qv2ray

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ghost
Copy link
Author

ghost commented Jan 24, 2024

nixpkgs-review pr 283551 rather than nixpkgs-review rev HEAD rebuilds tests.cc-wrapper.supported on x64 linux.

Result of nixpkgs-review pr 283551 run on x86_64-linux 1

1 package built:
  • tests.cc-wrapper.supported

@wegank

This comment was marked as resolved.

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 25, 2024
@ghost ghost changed the title drop llvmPackages_8 treewide: drop LLVM8 Jan 25, 2024
@delroth delroth removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 25, 2024
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 25, 2024
annalee added 3 commits January 25, 2024 12:23
darwin is marked broken
clang_8 is only used with darwin
removing references to llvmPackages_8 in preparation to drop it from the
tree
@delroth delroth removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 25, 2024
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 26, 2024
@ghost ghost mentioned this pull request Jan 26, 2024
@ghost ghost merged commit 425588f into NixOS:master Jan 30, 2024
24 checks passed
@ghost ghost deleted the llvmPackages_8-drop branch January 30, 2024 06:25
@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants