Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hobbes: unpin stdenv llvm #283678

Merged
merged 1 commit into from Jan 25, 2024
Merged

hobbes: unpin stdenv llvm #283678

merged 1 commit into from Jan 25, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jan 25, 2024

Description of changes

unpin llvm-10 in preparation to drop from the tree.

Result of nixpkgs-review pr 283678 run on x86_64-linux 1

1 package built:
  • hobbes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 25, 2024
@delroth delroth removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 25, 2024
@wegank wegank merged commit df3443b into NixOS:master Jan 25, 2024
21 of 23 checks passed
@ghost ghost deleted the hobbes-update-llvm branch January 25, 2024 13:25
@ghost ghost mentioned this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants