Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlPackages.llvm: unpin llvmPackages_10.libllvm #283685

Merged
merged 1 commit into from Jan 25, 2024
Merged

ocamlPackages.llvm: unpin llvmPackages_10.libllvm #283685

merged 1 commit into from Jan 25, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jan 25, 2024

Description of changes

remove LLVM-10 dependencies in preparation for removal from nixpkgs.

this change just updates the libllvm module to use the nixpkgs default, which is llvm-16.

Result of nixpkgs-review pr 283685 run on x86_64-linux 1

1 package built:
  • ocamlPackages.llvm

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ghost ghost requested review from vbgl and symphorien January 25, 2024 06:45
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 25, 2024
@ghost
Copy link
Author

ghost commented Jan 25, 2024

@ofborg build ocamlPackages.llvm

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 25, 2024
@delroth delroth added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Jan 25, 2024
@NickCao NickCao merged commit 6b79448 into NixOS:master Jan 25, 2024
28 checks passed
@ghost ghost mentioned this pull request Jan 26, 2024
@ghost ghost deleted the ocaml-packages-llvm branch February 8, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: ocaml 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants