lzip: add mingw support #285875
Merged
lzip: add mingw support #285875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ofborg build pkgs.pkgsCross.mingw32.lzip |
|
@ofborg build pkgs.pkgsCross.mingwW64.lzip |
wegank
reviewed
Feb 2, 2024
ofborg
bot
added
10.rebuild-darwin-stdenv
seanybaggins
force-pushed
the
add-mingw32-support-lzip
branch
from
9e60974 to
2621d3b
Compare
|
@ofborg build pkgs.pkgsCross.mingw32.lzip |
|
@ofborg build pkgs.pkgsCross.mingwW64.lzip |
wegank
reviewed
Feb 2, 2024
Part of a greater effort to get qtbase and qtmultimedia cross compiling for windows.
seanybaggins
force-pushed
the
add-mingw32-support-lzip
branch
from
2621d3b to
6269f31
Compare
|
@ofborg build pkgs.pkgsCross.mingw32.lzip |
|
@ofborg build pkgs.pkgsCross.mingwW64.lzip |
ofborg
bot
added
10.rebuild-darwin: 0
wegank
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
LGTM. There is currently a patch on the mailing list, which is stale and is not trivial anyway, because the patch there has to be unconditional, i.e. extension must be detected automatically.
Still, a possible improvement could be to apply substituteAll on the patch with stdenv.hostPlatform.extensions.executable. I'll leave it to the other reviewers to decide if they wish.
delroth
added
the
12.approvals: 1
Artturin
reviewed
Feb 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of a greater effort to get qtbase and qtmultimedia cross compiling for windows.
Description of changes
Added mingw support for lzip
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.