Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskell-modules: Pass -split-sections when cross-compiling #286317

Conversation

wolfgangwalther
Copy link
Contributor

This works around #286285 by passing --enable-split-sections instead of ghc-options.

This enables dead code elimination for pkgsCross and pkgsStatic, which did not work before.

Example: pkgsStatic.haskellPackages.cabal2nix

Before this change:

% du -h /nix/store/p9cl25mfl1l1gg5g9yvjfrqrrnywk9z0-cabal2nix-static-x86_64-unknown-linux-musl-2.19.1/bin/*
35M	/nix/store/p9cl25mfl1l1gg5g9yvjfrqrrnywk9z0-cabal2nix-static-x86_64-unknown-linux-musl-2.19.1/bin/cabal2nix
24M	/nix/store/p9cl25mfl1l1gg5g9yvjfrqrrnywk9z0-cabal2nix-static-x86_64-unknown-linux-musl-2.19.1/bin/hackage2nix

With this change:

% du -h /nix/store/q6nmkykk3im40lgvgy77njpr1d93gv7k-cabal2nix-static-x86_64-unknown-linux-musl-2.19.1/bin/*
15M	/nix/store/q6nmkykk3im40lgvgy77njpr1d93gv7k-cabal2nix-static-x86_64-unknown-linux-musl-2.19.1/bin/cabal2nix
9,5M	/nix/store/q6nmkykk3im40lgvgy77njpr1d93gv7k-cabal2nix-static-x86_64-unknown-linux-musl-2.19.1/bin/hackage2nix

Things done

  • Built on platform(s)
    • x86_64-linux: pkgsStatic.haskellPackages.cabal2nix
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This works around NixOS#286285 by passing --enable-split-sections instead of ghc-options.
@ofborg ofborg bot added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Feb 4, 2024
@delroth delroth added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Feb 4, 2024
@wolfgangwalther
Copy link
Contributor Author

Will be merged in #286941.

@wolfgangwalther wolfgangwalther deleted the split-sections-cross branch February 8, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: cross-compilation Building packages on a different platform than they will be used on 6.topic: haskell 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants