onnxruntime: fix aarch64-darwin #287255
onnxruntime: fix aarch64-darwin #287255
Conversation
|
@ofborg build onnxruntime |
There was a problem hiding this comment.
Oh, right, many people use Eigen...
There was a problem hiding this comment.
Ok I hope I avoided the mass ping issue
There was a problem hiding this comment.
@cbourjau I retargeted the PR for staging because it's a lot of rebuilds; if you need onnxruntime on aarch64-darwin working right now, you might have to submit a temporary hotfix (TM) for the master, doing essentially the ad hoc override much like the one you started with (only without fetchcontent)
...following cbourjau s idea
SomeoneSerge
force-pushed
the
fix/onnxruntime-darwin
branch
from
439b592 to
d56c63c
Compare
|
Thanks for looking into this! Might it make sense to only apply the patch for darwin since the build seems to be just fine on other systems? |
There was a problem hiding this comment.
Might it make sense to only apply the patch for darwin since the build seems to be just fine on other systems?
The original MR doesn't seem darwin-specific, and I personally dislike conditional patches (they're kind of like extra moving pieces, it's too real for my small reptile brain). We wouldn't save much either because once you have to bootstrap for one platform it's already "expensive"? I'm open to hear other opinions though
ofborg
bot
added
10.rebuild-darwin: 5001+
10.rebuild-darwin-stdenv
|
No log for the documentation failure looks like an unrelated staging issue… |
...following @cbourjau s suggestion
Follow-up to: #258392
Waiting for the build of interest (aarch64-darwin): https://github.com/NixOS/nixpkgs/pull/287255/checks?check_run_id=21366391259
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.