-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mingw support xvidcore #287540
Add mingw support xvidcore #287540
Conversation
Part of a larger effort to get mingw support for qtmultimedia
# Dependants of xvidcore don't know to look in bin for dependecies. Link them | ||
# in lib so other depedants of xvidcore can find the dlls. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please give an example
Can the hook be improved https://github.com/NixOS/nixpkgs/blob/master/pkgs/build-support/setup-hooks/win-dll-link.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ffmpeg is an example.
I think the hook can be improved. When creating my own windows application, I need to manually copy dlls to bin which is not ideal. See https://github.com/seanybaggins/qt-package-overalys/blob/bcd044bdba9be492e4694d096edb0bb4e9dbb027/nix/overlays/pkgs/qtapp-example/default.nix#L36-L43
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the hook can be improved. When creating my own windows application, I need to manually copy dlls to bin which is not ideal. See seanybaggins/qt-package-overalys@
bcd044b
/nix/overlays/pkgs/qtapp-example/default.nix#L36-L43
The /bin
copies/links should be done by the hook as long as you add the packages to buildInputs
.
Why would this cause a massive rebuild. Things appear to be properly gated to me. |
|
Should this be rebased to staging-next or staging? |
I think rebasing to -next would be ok but it should target staging |
Closing in favor of #288877 |
Description of changes
Add mingw support for xvidcore
Part of a larger effort to add mingw support for qtmultimedia
Relevant for #274274
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.