Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mingw support xvidcore #287540

Closed

Conversation

seanybaggins
Copy link
Contributor

Description of changes

Add mingw support for xvidcore

Part of a larger effort to add mingw support for qtmultimedia

Relevant for #274274

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Sorry, something went wrong.

Part of a larger effort to get mingw support for qtmultimedia
Comment on lines +38 to +39
# Dependants of xvidcore don't know to look in bin for dependecies. Link them
# in lib so other depedants of xvidcore can find the dlls.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ffmpeg is an example.

I think the hook can be improved. When creating my own windows application, I need to manually copy dlls to bin which is not ideal. See https://github.com/seanybaggins/qt-package-overalys/blob/bcd044bdba9be492e4694d096edb0bb4e9dbb027/nix/overlays/pkgs/qtapp-example/default.nix#L36-L43

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the hook can be improved. When creating my own windows application, I need to manually copy dlls to bin which is not ideal. See seanybaggins/qt-package-overalys@bcd044b/nix/overlays/pkgs/qtapp-example/default.nix#L36-L43

The /bin copies/links should be done by the hook as long as you add the packages to buildInputs.

@seanybaggins
Copy link
Contributor Author

Why would this cause a massive rebuild. Things appear to be properly gated to me.

@seanybaggins
Copy link
Contributor Author

@wegank

@Artturin
Copy link
Member

Artturin commented Feb 9, 2024

Why would this cause a massive rebuild. Things appear to be properly gated to me.

optionalString becomes "" on false which changes the derivation.

@seanybaggins
Copy link
Contributor Author

Should this be rebased to staging-next or staging?

@Mindavi
Copy link
Contributor

Mindavi commented Feb 14, 2024

I think rebasing to -next would be ok but it should target staging

@seanybaggins
Copy link
Contributor Author

Closing in favor of #288877

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants