Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python311Packages.tensorflow: llvmPackages_11 -> llvmPackages #288960

Merged
1 commit merged into from Feb 20, 2024
Merged

python311Packages.tensorflow: llvmPackages_11 -> llvmPackages #288960

1 commit merged into from Feb 20, 2024

Conversation

ghost
Copy link

@ghost ghost commented Feb 15, 2024

remove llvmPackages_11 reference in preparation to drop LLVM11 Note: darwin build is broken so building with llvmPackages is untested

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from abbradar February 15, 2024 05:27
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Feb 15, 2024
@ghost ghost mentioned this pull request Feb 15, 2024
remove llvmPackages_11 reference in preparation to drop LLVM11
Note: darwin build is broken so building with llvmPackages is untested
@ghost ghost merged commit cb29831 into NixOS:master Feb 20, 2024
22 of 23 checks passed
@ghost ghost deleted the tensorflow-llvm11-unpin branch February 20, 2024 03:15
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants