-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zfs: update latestCompatibleLinuxPackages #291547
Conversation
ZFS no longer tries to use GPL-only symbols on aarch64. Tested by building nixosTests.zfs.stable (modified to use Linux 6.6) and nixosTests.zfs.unstable.
e00d1f5
to
2b9f043
Compare
if stdenv'.isx86_64 || removeLinuxDRM | ||
then kernel.kernelOlder "6.9" | ||
else kernel.kernelOlder "6.2"; | ||
kernelCompatible = kernel.kernelOlder "6.9"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See also #291402
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we'll get a conflict when one of these PRs merges. It's an orthogonal change though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code seems good and reasonable. I do not have an aarch64 machine, so only did nix-build ---A pkgsCross.aarch64-multiplatform.linuxKernel.packages.linux_6_6.zfs
to test module build.
Thanks, nice to see this finally cleaned up. :) |
Description of changes
ZFS no longer tries to use GPL-only symbols on aarch64.
Tested by building nixosTests.zfs.stable (modified to use Linux 6.6) and nixosTests.zfs.unstable.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.