-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/pipewire: add assertions for migration to extraConfig
/configPackages
#291946
nixos/pipewire: add assertions for migration to extraConfig
/configPackages
#291946
Conversation
Need to look more carefully, but "deprecated" should be replaced by "removed". If the old ones don't work and it's an assert failure to use them it's not a deprecation. |
…Packages` The PR NixOS#282377 made files/directories specified in `environment.etc."pipewire<...>"` and `environment.etc."wireplumber<...>"` conflict with existing configuration of the PipeWire NixOS module due to how the `configPackages` options were implemented. This sadly wasn't easily avoidable. As this can cause breakage for users moving from 23.11 to 24.05 though, assertions can help guide them to use `services.pipewire.extraConfig` or `services.pipewire.configPackages` / `services.wireplumber.configPackages` instead, fixing the breakage.
2077e78
to
5f6dca8
Compare
I don't understand the decision to force an user to package WirePlumber rules to be able to write a few rules for WP. Is there a reason why this assertion was thrown in, but not an extraConfig option? |
This assertion PR was just a quick fix. I'm afraid the main PR was just not ready yet in hindsight. I'll work on a follow-up for an |
Is it possible to add this to the backwards incompatible changes section in the release notes? I ran into this issue and checked the release notes, but I was unable to figure out how to use the new option, since I did find this commit, which would help others experiencing the same. |
Document the breaking change caused by NixOS#282377. Assertions for better error messages for this breaking change were added in NixOS#291946. NixOS#292115 will add a better migration path for WirePlumber by adding `extraConfig` style options that previously did not exist for WirePlumber.
Description of changes
The PR #282377 made files/directories specified in
environment.etc."pipewire<...>"
andenvironment.etc."wireplumber<...>"
conflict with existing configuration of the PipeWire NixOS module due to how theconfigPackages
options were implemented. This sadly wasn't easily avoidable. As this can cause breakage for users moving from 23.11 to 24.05 though, assertions can help guide them to useservices.pipewire.extraConfig
orservices.pipewire.configPackages
/services.wireplumber.configPackages
instead, fixing the breakage.Wireplumber probably still needs an additional
extraConfig
andextraScrips
(orextraPolicies
,extraScripts
; open for bikeshedding) options.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.