Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpvScripts.uosc: 5.1.1 -> 5.2.0 #292868

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

uninsane
Copy link
Contributor

@uninsane uninsane commented Mar 2, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@plokid
Copy link

plokid commented Mar 23, 2024

Is this request still working on?

@uninsane
Copy link
Contributor Author

ping @apfelkuchen6

Copy link
Contributor

@apfelkuchen6 apfelkuchen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable and works fine on my machine (also tested with thumbfast).

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Mar 24, 2024
@plokid
Copy link

plokid commented Mar 28, 2024

@nbraud

@plokid
Copy link

plokid commented Apr 5, 2024

still in check? @nbraud

@Aleksanaa Aleksanaa merged commit 4ab65fb into NixOS:master Apr 8, 2024
29 checks passed
@nbraud
Copy link
Contributor

nbraud commented Apr 28, 2024

still in check? @nbraud

Hi! Sorry, I was pretty unresponsive the last couple of months, due to health issues and general awfulness.
This looks fine to me, thanks a lot for the PR, reviews, and merge <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants