llvmPackages_11.libcxx: symlink cxxabi libs into libcxx #295767
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
13 tasks
ofborg
bot
requested review from
rrbutani,
alyssais,
sternenseemann,
Ericson2314,
dtzWill,
lovek323 and
RaitoBezarius
present a unified libcxx / libcxxabi lib directory similar to LLVM12+ toolchains. This is required to for building darwin stdenvBootstrapTools which pins LLVM11 causing it to bootstrap a llvm11 stdenv but the bootstrapping code expects a unified libcxx / libcxxabi. Thus, builds which explicitly link to -lc++abi break as the libcxxabi is not in the linker search path. Symlinking libc++abi into libcxx/lib fixes this.
ghost
changed the title
|
eh. regardless of adding a symlink or using propagatedBuildInputs the stdenvBuildTools build fails with: going to spend my effort to just unpin LLVM11 rather than mess around with whatever the issue is here. error: output '/nix/store/aqn02d28riawi0h7819k6z2shyafkycs-stdenv-darwin' is not allowed to refer to the following paths:
/nix/store/axrhbnny1x7207hny0887j3rzz7snjid-libcxxabi-11.1.0
error: 1 dependencies of derivation '/nix/store/lirfy39xrraniq5ddvsp9wh65px6c3z3-apple-framework-CoreFoundation-11.0.0.drv' failed to build
error: 1 dependencies of derivation '/nix/store/25vwq5x4ya4j19h3gfsr3d3sd73b3q34-autoreconf-hook.drv' failed to build
error: 1 dependencies of derivation '/nix/store/ffqd3bwbv9fy35igxflfnz7bp2n3djba-libSystem-11.0.0.drv' failed to build
error: 1 dependencies of derivation '/nix/store/pqg80pwkkb969gi6f10fjcv5znlsyd81-nuke-references.drv' failed to build
error: 1 dependencies of derivation '/nix/store/yw6inckaz7mfprc7ypdv58zz52f17qb9-pkg-config-wrapper-0.29.2.drv' failed to build
error: 1 dependencies of derivation '/nix/store/axghn2d03vjqjgav1sa0vkvn2fcgp3xa-ps-adv_cmds-119.drv' failed to build
error: 1 dependencies of derivation '/nix/store/syy92g6f19l7iggdlvv1hqlsmw5xs1nc-stdenv-bootstrap-tools.drv' failed to build
error: build of '/nix/store/96gnq4vsslfijfd3l24s5v3q828ng3kz-stdenv-bootstrap-tools.drv', '/nix/store/syy92g6f19l7iggdlvv1hqlsmw5xs1nc-stdenv-bootstrap-tools.drv', '/nix/store/vbyji520aw5hbyp2w78g4rvycxqg9mds-test.drv' failed``` |
ghost
closed this
ghost
deleted the
rrbutani
added
the
6.topic: llvm/clang
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix stdenvBuildTools builds: https://hydra.nixos.org/build/253010316
workaround needed for building stdenvBuildTools which pins llvm11 but stdenv.darwin/default.nix dropped support (PR #292043) for compilers with non-unified libcxx / libcxxabi and thus cxxabi is not added to the extraPackages in cc-wrapper and path left out while linking. adding symlinks to libc++abi in libcxx/lib fixes this.
LLVM11 is slated for removal once unpinned from stdenvBuildTools (PR #295557) (it's only consumer).
the stdenvBuildTools have not been used to update the the bootstrap-tools tarball since 2020,2021.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.