Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt6.qtshadertools: add mingw support #296194

Merged

Conversation

seanybaggins
Copy link
Contributor

Part of a larger effort to add mingw support for qtmultimedia.
Relevant for #274274

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@seanybaggins
Copy link
Contributor Author

@ofborg build pkgs.pkgsCross.mingw32.qt6.qtshadertools

@seanybaggins
Copy link
Contributor Author

@ofborg build pkgs.pkgsCross.mingwW64.qt6.qtshadertools

@seanybaggins
Copy link
Contributor Author

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 15, 2024
Part of a larger effort to add mingw support for qtmultimedia.
@seanybaggins seanybaggins force-pushed the add-mingw-support-qt6-qtshadertools branch from 76ad9d8 to 930ce12 Compare March 15, 2024 21:11
@NickCao
Copy link
Member

NickCao commented Mar 16, 2024

@ofborg build pkgs.pkgsCross.mingw32.qt6.qtshadertools

@NickCao NickCao merged commit b04ddfe into NixOS:master Mar 16, 2024
22 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants