Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libxml2: Remove Darwin bootstrapping hack #296684

Merged
merged 1 commit into from
Mar 24, 2024
Merged

Conversation

jtojnar
Copy link
Member

@jtojnar jtojnar commented Mar 17, 2024

Description of changes

No longer appears to be needed? I successfully built libxml2 on Darwin community builder.

Reverts 36bb8d9.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@jtojnar jtojnar requested a review from vcunat March 17, 2024 16:02
@vcunat
Copy link
Member

vcunat commented Mar 17, 2024

Sounds good, if the two stdenvs build. I'm not sure if ofBorg can manage to confirm. Perhaps also build the other stdenv on the community darwin? (I see it listing both, rosetta2 surely.)

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Mar 17, 2024
@ghost
Copy link

ghost commented Mar 17, 2024

FWIW I removed this as part of my change to update the darwin bootstrap tools as building the older libxml2 crashes clang-16.

I can confirm x64 and aarch64 stdenv build with my changes which i am aiming to get in for the next staging cycle.

@ofborg ofborg bot added the 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild label Mar 17, 2024
@ofborg ofborg bot requested a review from edolstra March 17, 2024 17:20
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 17, 2024
@vcunat vcunat merged commit 448e50e into NixOS:staging Mar 24, 2024
31 checks passed
@jtojnar jtojnar deleted the libxml-no-old branch March 24, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants