ceph: workaround broken mgr modules #297136
Merged
+22
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is yet another incarnation of https://tracker.ceph.com/issues/64213 which was fixed for cryptography specifically (thus fixing dashboard) but since our bcrypt update NixOS#291195 every module broke for the same reason Until upstream manages to get this fixed permanently, I don't see that we can do much but "vendor" in these old deps. It may be possible to more delicately patch the rust package underneath bcrypt, but I'm not sure how
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
labels
|
I just ran into the same issue with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is yet another incarnation of https://tracker.ceph.com/issues/64213 which was fixed for cryptography specifically (thus fixing dashboard) but since our bcrypt update #291195 every module broke for the same reason
Until upstream manages to get this fixed permanently, I don't see that we can do much but "vendor" in these old deps.
It may be possible to more delicately patch the rust package underneath bcrypt, but I'm not sure how
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.