diagon: init @ 1.1.158 #297736
Open
diagon: init @ 1.1.158 #297736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: package (new)
applePrincess
suggested changes
Mar 21, 2024
|
Result of 1 package built:
|
Sure, done |
|
Could you rebase this repo so that ff6a2e4 is not part of this PR. |
|
Result of 1 package built:
|
applePrincess
approved these changes
Mar 23, 2024
wegank
added
the
12.approvals: 1
|
Hi @applePrincess, I'm not sure what is supposed to happen with this. Would you please let me know what I need to do next to have this merged? Thank you. |
|
Not really. I do not have rights to merge so I can not make it happen but you can mention this PR on Discourse. |
sikmir
reviewed
Sep 13, 2024
Comment on lines
+47
to
+51
| nativeBuildInputs = [ | ||
| boost184 | ||
| cmake | ||
| jdk | ||
| ]; |
There was a problem hiding this comment.
Suggested change
| nativeBuildInputs = [ | |
| boost184 | |
| cmake | |
| jdk | |
| ]; | |
| nativeBuildInputs = [ | |
| cmake | |
| jdk | |
| ]; | |
| buildInputs = [ | |
| boost184 | |
| ]; |
sikmir
reviewed
Sep 13, 2024
| description = "An interactive interpreter that transforms markdown-style expression into an ascii-art representation"; | ||
| license = lib.licenses.mit; | ||
| maintainers = [ lib.maintainers.petertrotman ]; | ||
| mainProgram = "diagon"; |
There was a problem hiding this comment.
Suggested change
| mainProgram = "diagon"; | |
| mainProgram = "diagon"; | |
| platforms = lib.platforms.unix; |
wegank
added
the
2.status: merge conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added package for diagon and myself as maintainer.
https://github.com/ArthurSonzogni/Diagon
Diagon is an interactive interpreter. It transforms markdown-style expression into an ascii-art representation.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.