saunafs: init at 4.0.1 #297811
saunafs: init at 4.0.1 #297811
Conversation
|
This is a draft! |
ofborg
bot
added
10.rebuild-darwin: 0
and removed
10.rebuild-darwin: 1
10.rebuild-darwin: 1-10
labels
|
|
||
| buildInputs = [ | ||
| (boost175.override { stdenv = gcc11Stdenv; }) | ||
| (yaml-cpp.override { stdenv = gcc11Stdenv; }) |
There was a problem hiding this comment.
Can you provide a comment why this override is needed?
There was a problem hiding this comment.
Because of gcc11Stdenv.mkDerivation, without overriding stdenv, linking errors will be thrown
There was a problem hiding this comment.
There is an assumption that saunafs was written for Ubuntu 18, which uses the old gcc. Since gcc 12 has some compatibility issues with legacy code, it is necessary to use the old gcc for saunafs.
Example gcc11<->gcc12 incompatibility - some operations are no longer considered constexpr
There was a problem hiding this comment.
You can see ther examples of fixing issues like this here:
yanet-platform/yanet@main...GeorgyKirichenko:yanet:fix-compilation
There was a problem hiding this comment.
In YANET, before the fixes, gcc 11 (or older) was also needed
|
Also implemented in later opened #314811. |
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.