nodejs_20: 20.11.1 -> 20.12.0

[marsam]

Changelog: https://github.com/nodejs/node/releases/tag/v20.12.0

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[bradzacher]

I notice this was merged into staging and not master.
What's the workflow for promoting this to master?

[jakubm-canva]

@marsam - is there a timeline to promote to master?

[marsam]

Hi, sorry for the delay

I notice this was merged into staging and not master.

yes, I usually send nodejs_20 to staging, because building it locally is resource intensive, and it may hurt contributors that use master branch. However, security releases always land in master first.

What's the workflow for promoting this to master?

Do you mean the staging workflow? I think it's documented in RFC 26 and CONTRIBUTING.md.

is there a timeline to promote to master?

The previous staging-next branch was merged a couple of days ago. So, I expect this to land in master during the week of April 15.

btw, is there anything in this version that could have been better if it landed in master first?

[jakubm-canva]

Thanks for the update.

There is an important fix that makes the network connections not to fail: nodejs/node#51045
That's pretty much all in it.

[jakubm-canva]

@marsam - any updates on the merge to master?

[marsam]

it's already on master (staging-next PR #303527)

[vcunat]

Generally you can use tools like https://nixpk.gs/pr-tracker.html?pr=299327

[bradzacher]

That would be great to have a bot auto-post that link for discoverability!