sunshine: use pkgs.autoAddDriverRunpath #300287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
10.rebuild-darwin: 0
|
@jonringer I think this may still need autoPatchelfHook for some vendored libraries or it will crash on run, but I’ll test and let you know. |
Yea, I always call it now. I feel like a |
pkgs/servers/sunshine/default.nix
Outdated
| @@ -84,10 +85,10 @@ stdenv'.mkDerivation rec { | |||
| nativeBuildInputs = [ | |||
| cmake | |||
| pkg-config | |||
| autoPatchelfHook | |||
| autoAddDriverRunpath | |||
There was a problem hiding this comment.
Moved out of optionals
jonringer
force-pushed
the
sunshine-autoadd
branch
from
6ef9a4f
to
0df9f80
Compare
devusb
approved these changes
Apr 1, 2024
SomeoneSerge
approved these changes
Apr 1, 2024
wegank
added
12.approvals: 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Part of #141803
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.