Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove references to mdDoc in the manual #300738

Merged
merged 12 commits into from
Apr 1, 2024
Merged

doc: remove references to mdDoc in the manual #300738

merged 12 commits into from
Apr 1, 2024

Conversation

philiptaron
Copy link
Contributor

Description of changes

Since #237557 was merged, lib.mdDoc has been a no-op. Let's remove the manual entries that recommend it.

The tracking issue is #300735.

Things done

  • nix-build doc/default.nix

@philiptaron philiptaron requested a review from a team April 1, 2024 16:56
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation labels Apr 1, 2024
@philiptaron philiptaron requested a review from a team as a code owner April 1, 2024 17:04
@github-actions github-actions bot added the 6.topic: testing Tooling for automated testing of packages and modules label Apr 1, 2024
@philiptaron
Copy link
Contributor Author

philiptaron commented Apr 1, 2024 •
edited
Loading

Hrm, I meant to separate nixos/lib changes into a separate PR. Oh well, it didn't make this one too much bigger.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Apr 1, 2024
DanielSidhion
DanielSidhion approved these changes Apr 1, 2024
View reviewed changes
Copy link
Member

@DanielSidhion DanielSidhion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, didn't see any weird formatting issues.

@DanielSidhion
Copy link
Member

Given the very specific scope of this PR, I'm going ahead with a merge even though ideally the manual and nixos/lib changes should've been done in separate PRs.

@DanielSidhion DanielSidhion merged commit ebde306 into NixOS:master Apr 1, 2024
22 checks passed
@philiptaron
Copy link
Contributor Author

philiptaron commented Apr 2, 2024 •
edited
Loading

Given the very specific scope of this PR, I'm going ahead with a merge even though ideally the manual and nixos/lib changes should've been done in separate PRs.

Thank you 🙇🏻‍♂️ I wish there was something in that git push workflow that caused me to halt a little more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielSidhion DanielSidhion DanielSidhion approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: testing Tooling for automated testing of packages and modules 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philiptaron @DanielSidhion