Rust 1.20.0 #30088

zimbatm · 2017-10-04T16:56:54Z

Motivation for this change

Updating the rust package and cleaning things up a bit. In general nixpkgs doesn't hold unstable software unless there is a specific need so I suggest to remove beta and nightly and rely on nixpkgs-mozilla for those.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- Linux
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

Newly-broken packages

A number of packages were broken by the update (or just exposed as already broken):

pkgs/applications/misc/alacritty/default.nix (no release, git dependencies)
pkgs/applications/networking/cluster/habitat/default.nix (git dependencies)

error: failed to sync

Caused by:
  found duplicate version of package `urlencoded v0.5.0` vendored from two sources:

        source 1: https://github.com/iron/urlencoded#8157212e
        source 2: registry https://github.com/rust-lang/crates.io-index

pkgs/applications/window-managers/way-cooler/default.nix (compiler error, new upstream release)
pkgs/applications/window-managers/wtftw/default.nix (no release, unmaintianed)

error: the lock file needs to be updated but --locked was passed to prevent this

pkgs/development/tools/misc/tokei/default.nix (cc @gebner )

error: the lock file needs to be updated but --locked was passed to prevent this

pkgs/development/tools/rust/rainicorn/default.nix (no maintainer, unstable)

warning: path `src/main.rs` was erroneously implicitly accepted for binary parse_describe,

pkgs/tools/package-management/cargo-edit/default.nix (new upstream release)
pkgs/tools/text/staccato/default.nix (new upstream release)
pkgs/applications/altcoins/ethrun.nix (new upstream release)

LnL7 · 2017-10-04T21:33:11Z

I agree that we should remove the nightly builds. However there's an alias for rustNightly that causes an evaluation error.

andir · 2017-10-05T08:34:03Z

You should probably also remove the references (to beta and nightly versions) in the docs (doc/languages-frameworks/rust.md).

Mic92 · 2017-10-05T08:40:34Z

I start nix-review now.

zimbatm · 2017-10-05T09:57:34Z

ok I fixed the doc as well. there is a last thing I want to do but on the nixpkgs-mozilla overlay: it should be aligned so that makeRustPlatform latest.rustChannels.beta would work.

Mic92 · 2017-10-05T10:51:38Z

I get the following test failures, when running the rust test suite:

https://gist.github.com/anonymous/95cefd8f364351b17294c59a9fe56be8

From the commandline arguments it looks, like it does something with adb? I think we can disable that test. The other one looks more serious.

mguentner · 2017-10-05T16:41:54Z

@Mic92 Seems like this is related:
#28459 (comment)
apparently it has been fixed (?) in rust-lang/rust#43026

mguentner · 2017-10-05T21:16:09Z

Maybe we need rust's llvm fork https://github.com/rust-lang/llvm/ 🦊

the rust project has forked the llvm compiler to solve some issues. With pkgs.llvm the test suite fails. See rust-lang/rust#43026 And PR NixOS#30088

mguentner · 2017-10-06T22:20:19Z

Still seeing #28459 (comment) after these
commits:
https://github.com/mguentner/nixpkgs/tree/rust_30088

Very sad. 🎺

ghost · 2017-10-08T16:04:26Z

I would recommend jumping straight to Rust v1.21 since that is releasing in a few days.

zimbatm · 2017-10-08T23:12:44Z

It looks like cargo has a new way of creating crates.io-index mirrors. See http://doc.crates.io/source-replacement.html . I'm trying to untangle how everything work and come up with a more stable solution.

Mic92 · 2017-10-09T10:50:48Z

Actually it should be easier now to provide a custom replacement for the official registry.

bachp · 2017-10-09T13:47:09Z

@Mic92 @zimbatm I think you are talking about #27964

mguentner · 2017-10-09T13:53:51Z

@bachp yes. Thank you.

zimbatm · 2017-10-09T14:51:48Z

merging more stuff into this PR :)

zimbatm · 2017-10-09T15:08:17Z

success! it's a mess so I will cleanup the branch a bit

Mic92 · 2017-10-09T16:46:38Z

Did you forgot to add something?

error: while evaluating 'callPackageWith' at /home/joerg/git/nixpkgs/.review/pr-30088-s6ksz1c1/lib/customisation.nix:113:35, called from /home/joerg/git/nixpkgs/.review/pr-30088-s6ksz1c1/pkgs/top-level/all-packages.nix:6187:18:
while evaluating 'makeOverridable' at /home/joerg/git/nixpkgs/.review/pr-30088-s6ksz1c1/lib/customisation.nix:72:24, called from /home/joerg/git/nixpkgs/.review/pr-30088-s6ksz1c1/lib/customisation.nix:117:8:
getting status of '/home/joerg/git/nixpkgs/.review/pr-30088-s6ksz1c1/pkgs/top-level/rust-packages.nix': No such file or directory

bachp · 2017-10-09T16:55:07Z

@zimbatm I wrote an alternative version of the print-hashes script that doesn't required the date and prints an attr set that can be pasted directly into the .nix file.

My plan was to submit this while adding support for aarch64, but it might be helpful here already.

vcunat · 2017-10-16T12:06:56Z

@wizeman: I see. Thanks. I suppose I'll have to get used to waiting a long time for Firefox...

mguentner · 2017-10-16T16:43:41Z

cargo 0.22.0 has been released https://github.com/rust-lang/cargo/releases/tag/0.22.0 which includes rust-lang/cargo@5b08b8f and thus should form the base for dhovart/cargo-local-registry#9 (so many meta-dependencies! 😥)

zimbatm · 2017-10-19T13:52:40Z

I have replaced the dependency fetching method to use cargo-vendor and it seems to be producing much more stable sha256. Anyone wants to nox-review?

zimbatm · 2017-10-19T15:11:29Z

Currently rebasing, please don't push anything

zimbatm · 2017-10-20T10:38:24Z

It's working but programs who depend one git are still problematic. The issue is that the .cargo/config should contain an override for all the targets.

Is it acceptable for now to mark all these packages as broken and move on?

zimbatm · 2017-10-20T12:36:39Z

Once we have alexcrichton/cargo-vendor#53 it will be easier to generate the .cargo/config and store it alongside the vendor output

zimbatm · 2017-10-22T23:28:59Z

Even with the generated cargo config, cargo seems to need the git repos to work properly :/

zimbatm · 2017-10-22T23:29:13Z

I think that we should just merge that for now

nixpkgs is for stable software. If you want beta and nightly, use the nixpkgs-mozilla overlay.

simplify the boostrap hashes a bit build with bundled llvm: the rust project has forked the llvm compiler to solve some issues. With pkgs.llvm the test suite fails. See rust-lang/rust#43026 And PR NixOS#30088

The biggest benefit is that we no longer have to update the registry package. This means that just about any cargo package can be built by nix. No longer does `cargo update` need to be feared because it will update to packages newer then what is available in nixpkgs. Instead of fetching the cargo registry this bundles all the source code into a "vendor/" folder. This also uses the new --frozen and --locked flags which is nice. Currently cargo-vendor only provides binaries for Linux and macOS 64-bit. This can be solved by building it for the other architectures and uploading it somewhere (like the NixOS cache). This also has the downside that it requires a change to everyone's deps hash. And if the old one is used because it was cached it will fail to build as it will attempt to use the old version. For this reason the attribute has been renamed to `cargoSha256`. Authors: * Kevin Cox <kevincox@kevincox.ca> * Jörg Thalheim <Mic92@users.noreply.github.com> * zimbatm <zimbatm@zimbatm.com>

See #30088.

ghost · 2017-12-13T10:45:58Z

@zimbatm

pkgs/applications/window-managers/way-cooler/default.nix (compiler error, new upstream release)

Will be fixed by #32285

zimbatm requested review from madjar, cstrahan, wizeman, globin and wkennington October 4, 2017 16:56

LnL7 added 6.topic: rust 8.has: clean-up labels Oct 4, 2017

andir mentioned this pull request Oct 5, 2017

(rustc, cargo): (1.17.0, 0.18.0) -> (1.19.0, 0.20.0) #28459

Closed

8 tasks

mguentner added a commit to mguentner/nixpkgs that referenced this pull request Oct 6, 2017

rust: build with bundled llvm

497e146

the rust project has forked the llvm compiler to solve some issues. With pkgs.llvm the test suite fails. See rust-lang/rust#43026 And PR NixOS#30088

zimbatm mentioned this pull request Oct 9, 2017

release? dhovart/cargo-local-registry#11

Closed

zimbatm force-pushed the rust-1.20.0 branch from 61203e7 to 508b264 Compare October 9, 2017 15:15

zimbatm force-pushed the rust-1.20.0 branch 2 times, most recently from b787ca1 to 523ae7d Compare October 19, 2017 13:51

zimbatm force-pushed the rust-1.20.0 branch from e492dfd to e709716 Compare October 19, 2017 22:13

zimbatm mentioned this pull request Oct 20, 2017

missing registry = line alexcrichton/cargo-vendor#55

Closed

zimbatm and others added 6 commits October 23, 2017 00:30

rust: remove beta and nightly releases

1d6eaac

nixpkgs is for stable software. If you want beta and nightly, use the nixpkgs-mozilla overlay.

rust: unbreak building with bundled LLVM

e30e201

rust: 1.17.0 -> 1.20.0

7bd191d

simplify the boostrap hashes a bit build with bundled llvm: the rust project has forked the llvm compiler to solve some issues. With pkgs.llvm the test suite fails. See rust-lang/rust#43026 And PR NixOS#30088

cargo: use fetchFromGitHub

d170c2c

cargo: 0.21.1 -> 0.22.0

6bbce42

zimbatm force-pushed the rust-1.20.0 branch from 9a1a04c to 6bbce42 Compare October 22, 2017 23:30

zimbatm merged commit 2d59a62 into NixOS:master Oct 22, 2017

zimbatm deleted the rust-1.20.0 branch October 22, 2017 23:31

Ma27 mentioned this pull request Oct 23, 2017

uutils/coreutils #28114

Closed

ljli mentioned this pull request Oct 23, 2017

buildRustPackage: found duplicate version of package #30742

Open

gebner added a commit that referenced this pull request Nov 2, 2017

tokei: fix build

d0d9ed6

See #30088.

orivej mentioned this pull request Nov 2, 2017

svgbobrus: init at 2017-08-29 #28819

Closed

8 tasks

ghost mentioned this pull request Dec 3, 2017

Make less known wayland compositors usable #32285

Merged

20 tasks

matthiasbeyer mentioned this pull request Jan 9, 2018

rust build support: Find Cargo.lock file upwards in tree #30412

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rust 1.20.0 #30088

Rust 1.20.0 #30088

zimbatm commented Oct 4, 2017 •

edited

Loading

LnL7 commented Oct 4, 2017

andir commented Oct 5, 2017 •

edited

Loading

Mic92 commented Oct 5, 2017

zimbatm commented Oct 5, 2017

Mic92 commented Oct 5, 2017 •

edited

Loading

mguentner commented Oct 5, 2017

mguentner commented Oct 5, 2017

mguentner commented Oct 6, 2017

ghost commented Oct 8, 2017

zimbatm commented Oct 8, 2017

Mic92 commented Oct 9, 2017

bachp commented Oct 9, 2017

mguentner commented Oct 9, 2017

zimbatm commented Oct 9, 2017

zimbatm commented Oct 9, 2017

Mic92 commented Oct 9, 2017

bachp commented Oct 9, 2017

vcunat commented Oct 16, 2017

mguentner commented Oct 16, 2017

zimbatm commented Oct 19, 2017

zimbatm commented Oct 19, 2017

zimbatm commented Oct 20, 2017

zimbatm commented Oct 20, 2017

zimbatm commented Oct 22, 2017

zimbatm commented Oct 22, 2017

ghost commented Dec 13, 2017 •

edited by ghost

Loading

Rust 1.20.0 #30088

Rust 1.20.0 #30088

Conversation

zimbatm commented Oct 4, 2017 • edited Loading

Motivation for this change

Things done

Newly-broken packages

LnL7 commented Oct 4, 2017

andir commented Oct 5, 2017 • edited Loading

Mic92 commented Oct 5, 2017

zimbatm commented Oct 5, 2017

Mic92 commented Oct 5, 2017 • edited Loading

mguentner commented Oct 5, 2017

mguentner commented Oct 5, 2017

mguentner commented Oct 6, 2017

ghost commented Oct 8, 2017

zimbatm commented Oct 8, 2017

Mic92 commented Oct 9, 2017

bachp commented Oct 9, 2017

mguentner commented Oct 9, 2017

zimbatm commented Oct 9, 2017

zimbatm commented Oct 9, 2017

Mic92 commented Oct 9, 2017

bachp commented Oct 9, 2017

vcunat commented Oct 16, 2017

mguentner commented Oct 16, 2017

zimbatm commented Oct 19, 2017

zimbatm commented Oct 19, 2017

zimbatm commented Oct 20, 2017

zimbatm commented Oct 20, 2017

zimbatm commented Oct 22, 2017

zimbatm commented Oct 22, 2017

ghost commented Dec 13, 2017 • edited by ghost Loading

zimbatm commented Oct 4, 2017 •

edited

Loading

andir commented Oct 5, 2017 •

edited

Loading

Mic92 commented Oct 5, 2017 •

edited

Loading

ghost commented Dec 13, 2017 •

edited by ghost

Loading