Revert "xonsh: set dontWrapPythonPrograms"

[SamLukeYes]

This reverts commit b640371.

Description of changes

A quick fix that resolves #301444

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[SamLukeYes]

It shouldn't be necessary tho -- why do we need to re-introduce wrappers to xonsh-unwrapped 😕

[LordGrimmauld]

running into this myself. Sadly the unwrapped xonsh isn't available by itself so overriding dontWrapPythonPrograms = false in an overlay is bothersome. Ideally xonsh-unwrapped would be available as a package itself....

The reason xonsh is wrapped in the first place is #240246, providing a way to add extra python packages that can be imported. The base package was pretty much kept without major changes that would allow it to not be wrapped at all.

[FlyingWombat]

Sadly the unwrapped xonsh isn't available by itself so overriding...

Agreed, xonsh wrapper needs re-work. Since xonsh-unwrapped is unavailable, I can't build my own version from git in an overlay, only by editing nixpkgs.

[FlyingWombat]

This changes builds and works for me.

[LordGrimmauld]

Fix is needed. Seeing as you were the one removing the wrapping, i see no issue with you putting it back. But eventually xonsh-unwrapped should be available by itself and maybe less hacky too...

[SuperSandro2000]

Likely this is caused by #297628