llvmPackages_9: remove due to age

[RossComputerGuy]

Description of changes

Part of #283954

CC @wegank

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

Follow up from #284865

---

Add a 👍 reaction to pull requests you find important.

[ghost]

can remove this too:

nixpkgs/pkgs/build-support/cc-wrapper/default.nix

Lines 565 to 569 in 34852dd

	# can remove once LLVM9 and LLVM11 are dropped from nixpkgs
	+ optionalString (libcxx.isLLVM or false && lib.versionOlder (lib.getVersion libcxx) "12" && libcxx ? cxxabi.libName) ''
	echo "-isystem ${lib.getDev libcxx.cxxabi}/include/c++/v1" >> $out/nix-support/libcxx-cxxflags
	echo "-l${libcxx.cxxabi.libName}" >> $out/nix-support/libcxx-ldflags
	''

and should add aliases and an entry in pkgs/test/default.nix. see:
https://github.com/NixOS/nixpkgs/pull/283591/files#diff-308706790568e4d1381f5ab493c6eed2c30917e88ec06ae08d4ba9f049e8b64a

[RossComputerGuy]

can remove this too:

nixpkgs/pkgs/build-support/cc-wrapper/default.nix

Lines 565 to 569 in 34852dd

	# can remove once LLVM9 and LLVM11 are dropped from nixpkgs
	+ optionalString (libcxx.isLLVM or false && lib.versionOlder (lib.getVersion libcxx) "12" && libcxx ? cxxabi.libName) ''
	echo "-isystem ${lib.getDev libcxx.cxxabi}/include/c++/v1" >> $out/nix-support/libcxx-cxxflags
	echo "-l${libcxx.cxxabi.libName}" >> $out/nix-support/libcxx-ldflags
	''

and should add aliases and an entry in pkgs/test/default.nix. see: https://github.com/NixOS/nixpkgs/pull/283591/files#diff-308706790568e4d1381f5ab493c6eed2c30917e88ec06ae08d4ba9f049e8b64a

Looks good now?

[ghost]

LGTM tho should verify xeus-cling builds

[RossComputerGuy]

LGTM tho should verify xeus-cling builds

Yeah, I don't know anything about xeus-cling so someone who does know about it should look into it.

[wegank]

xeus-cling isn't compatible with recent versions of LLVM yet, so probably should be marked as broken. Or there's a simple fix, from jupyter-xeus/xeus-cling#513:

  postPatch = ''
    substituteInPlace src/xmagics/executable.cpp \
      --replace "getDataLayout" "getDataLayoutString"
    substituteInPlace src/xmagics/execution.cpp \
      --replace "simplisticCastAs" "castAs"
    substituteInPlace src/xmime_internal.hpp \
      --replace "code.str()" "code.str().str()"
  '';

[RossComputerGuy]

xeus-cling isn't compatible with recent versions of LLVM yet, so probably should be marked as broken. Or there's a simple fix, from jupyter-xeus/xeus-cling#513:

  postPatch = ''
    substituteInPlace src/xmagics/executable.cpp \
      --replace "getDataLayout" "getDataLayoutString"
    substituteInPlace src/xmagics/execution.cpp \
      --replace "simplisticCastAs" "castAs"
    substituteInPlace src/xmime_internal.hpp \
      --replace "code.str()" "code.str().str()"
  '';

The patch just seems simpler.

[ghost]

@ofborg build xeus-cling xeus-cling.passthru.tests

[ghost]

woot!