kakoune-lsp: 16.0.0 -> 17.1.1

[deviant]

Description of changes

The Perl patch no longer applied, so along with creating a new version of it, I took the liberty to clean up the package overall.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[matthiasbeyer]

Result of nixpkgs-review pr 302761 run on x86_64-linux 1

1 package built:

• kakoune-lsp (kakounePlugins.kakoune-lsp)

[alexshpilkin]

Verified basic functionality (clangd integration).

[2xsaiko]

This (and also the current version of this package) needs a newer Kakoune version, it broke my configuration:

Error: 2:9: 'add-highlighter': wrong parameter count (NOTE: lsp-inlay-diagnostics-enable requires Kakoune >= 2024)

[alexshpilkin]

@2xsaiko Right, inlay stuff in kakoune-lsp ≥ 16 requires git (unreleased) Kakoune; but at least ≥ 17 (this PR, or anything including kakoune-lsp/kakoune-lsp@86ceae0) will tell you what’s wrong instead of crashing incomprehensibly.

As far as cutting a release of Kakoune, we’re probably at the mercy of @mawww here as opposed to the Nixpkgs maintainerdom—you don’t usually get unreleased versions in Nixpkgs unless there’s no choice.

[deviant]

To anyone who wants to use inlay diagnostics with the current stable version of Kakoune, add the following to the patches of kakoune-unwrapped:

# "Support -after switch for flag-lines highlighter"
# Needed by kakoune-lsp v16.0.0+ for inlay diagnostics.
(fetchpatch2 {
  url = "https://github.com/mawww/kakoune/commit/c124c8f517c921bee2017cdf5081f3e8b98e27b9.patch";
  hash = "sha256-R+B29aKb9WGgEmNmVN0ZL0wPWrBFcTYglVBfhCjKENQ=";
  includes = [ "src/highlighters.cc" ];
})

I've been using this for a while with no issues.

[alois31]

The new version seems to work very well, including code actions when perl is not in PATH (which was previously broken).

[L-as]

what's blocking this from being merged?

[QiBaobin]

can we review and merge this? There is even an 17.1.1 out for a while.

[deviant]

I've fixed the conflict. Can someone merge this finally? Once that's done it'd be a simple matter for someone to bump it from there to the latest version.

[deviant]

Correction: have now fixed the conflict without using the web UI (which somehow produced an incorrect commit). Should be good to go now.

[philiptaron]

Thanks for keeping this patch running. I'm back in the saddle and looking to merge once a few things are tidied up.

[deviant]

I'm not looking to make further changes on this, sorry. In the several months it took for anyone to actually look at this PR, I've entirely stopped using Nix on any of my machines, so this isn't really a priority for me now.

[philiptaron]

I'm not looking to make further changes on this, sorry.

Understood. Would you mind if I did so?

[deviant]

You're welcome to! :) Please try to keep my authorship metadata intact, depending on how you go about this.

[philiptaron]

You're welcome to! :) Please try to keep my authorship metadata intact, depending on how you go about this.

I'll do my very best. 🙇🏻

[L-as]

Thanks!

[L-as]

Funnily enough this broke basically immediately because of #332957

[philiptaron]

• chore(deps): run cargo update to fix Rust 1.80 build kakoune-lsp/kakoune-lsp#764

I can confirm the following update now makes it build.

[philiptaron]

Funnily enough this broke basically immediately because of #332957

• kakounePlugins.kakoune-lsp: 17.1.1 -> 17.1.2 (fix build) #335266