-
-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handheld-daemon-ui: init at 3.2.1 #305027
base: master
Are you sure you want to change the base?
Conversation
Was surprised to see an AppImage and did some digging:
|
Not familiar with building npm/electron stuff from source and looking at the pr it seems kinda complicated, but I'll try and see if I can get it to work. |
I can't get this to build from source EDIT: Yeah, I give up. |
9c79539
to
18cd880
Compare
I've dropped the merge commit from the PR because that usually only causes trouble. |
You probably also want |
I wanted to add that on a different pr, since you need to add handheld-daemon-ui and lsof to handheld-daemon's service path for the steam/gamescope overlay to work, but I guess it does make sense to have that here |
@@ -31,6 +40,11 @@ in | |||
|
|||
restartIfChanged = true; | |||
|
|||
path = mkIf cfg.ui.enable [ | |||
pkgs.handheld-daemon-ui |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this should be wrapped inside the UI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accidentally started a review instead of commenting so I'll post my comment again:
I'm not sure what you mean?
Handheld-daemon needs the ui to be in it's PATH, so I would need to wrap handheld-daemon, not the ui
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
Changed some of the commit messages since the commits changing the module didn't start with |
Description of changes
New package: https://github.com/hhd-dev/hhd-ui/
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.