feishin: fix darwin builds #305344
Merged
feishin: fix darwin builds #305344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
6.topic: darwin
ofborg
bot
added
11.by: package-maintainer
|
It's working for me! Thanks! |
wegank
reviewed
Apr 24, 2024
jlbribeiro
force-pushed
the
feishin-0.6.1-darwin
branch
2 times, most recently
from
dd60d95 to
adaf52d
Compare
wegank
reviewed
Apr 30, 2024
Addresses the comment NixOS#303638 (comment) following NixOS#303638.
Follows NixOS#303638 and feishin darwin builds' fix.
wegank
force-pushed
the
feishin-0.6.1-darwin
branch
from
adaf52d to
5124a8d
Compare
github-actions
bot
added
the
8.has: maintainer-list (update)
wegank
approved these changes
Apr 30, 2024
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
and removed
10.rebuild-darwin: 0
|
@wegank Thank you so much for the review, fixes and merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
darwinbuilds, broken after feishin: 0.5.1 -> 0.6.1, build from source #303638 (Electron "from source" packaging), as mentioned here. This takes an approach similar to drawio: unbreak on darwin #262081 and bruno: fix darwin builds #280825.app-update.ymlafter disabling code signing (and "direct" updates wouldn't be possible in any platform anyway).@lunik1, I kindly ask you to test this and see if it works on your
darwinsystem now :) (including whether it plays any sound)I tested it on a macOS Sonoma
x86_64-darwinVM. The app only shows in Launchpad (but not on Applications nor Spotlight); I understand there are a couple of open issues innix-darwinregarding similar behavior, so I'm not 100% sure whether this is a packaging issue or just a Nix-on-macOS issue. I usednix-darwinwith a very basic (i.e. no post-activation scripts + no Home Manager) config to install it. (Installedbrunoand it had the same issues.)Maintainer: @onny
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.