Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python311Packages.uproot: 5.3.2 -> 5.3.6, python311Packages.coffea: 2024.4.1 -> 2024.5.0 #307316

Merged
merged 2 commits into from
May 15, 2024
Merged

python311Packages.uproot: 5.3.2 -> 5.3.6, python311Packages.coffea: 2024.4.1 -> 2024.5.0 #307316

merged 2 commits into from
May 15, 2024

Conversation

GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Apr 27, 2024 •
edited
Loading

Description of changes

Changelog: https://github.com/scikit-hep/uproot5/releases/tag/v5.3.4

cc @veprbl

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 307316 run on aarch64-darwin 1

4 packages failed to build:
  • python311Packages.coffea
  • python311Packages.coffea.dist
  • python311Packages.dask-awkward
  • python311Packages.dask-awkward.dist
6 packages built:
  • python311Packages.mplhep
  • python311Packages.mplhep.dist
  • python311Packages.uproot
  • python311Packages.uproot.dist
  • python312Packages.uproot
  • python312Packages.uproot.dist

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 307316 run on x86_64-darwin 1

4 packages failed to build:
  • python311Packages.coffea
  • python311Packages.coffea.dist
  • python311Packages.dask-awkward
  • python311Packages.dask-awkward.dist
6 packages built:
  • python311Packages.mplhep
  • python311Packages.mplhep.dist
  • python311Packages.uproot
  • python311Packages.uproot.dist
  • python312Packages.uproot
  • python312Packages.uproot.dist

@ofborg ofborg bot requested a review from veprbl April 27, 2024 21:52
@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 307316 run on x86_64-linux 1

2 packages failed to build:
  • python311Packages.coffea
  • python311Packages.coffea.dist
8 packages built:
  • python311Packages.dask-awkward
  • python311Packages.dask-awkward.dist
  • python311Packages.mplhep
  • python311Packages.mplhep.dist
  • python311Packages.uproot
  • python311Packages.uproot.dist
  • python312Packages.uproot
  • python312Packages.uproot.dist

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 307316 run on aarch64-linux 1

2 packages failed to build:
  • python311Packages.coffea
  • python311Packages.coffea.dist
8 packages built:
  • python311Packages.dask-awkward
  • python311Packages.dask-awkward.dist
  • python311Packages.mplhep
  • python311Packages.mplhep.dist
  • python311Packages.uproot
  • python311Packages.uproot.dist
  • python312Packages.uproot
  • python312Packages.uproot.dist

@GaetanLepage
Copy link
Contributor Author

This version apparently breaks some coffea tests.
Let's hold this update until the next release.

@GaetanLepage GaetanLepage force-pushed the uproot branch 2 times, most recently from 7112c05 to ae53a2c Compare May 6, 2024 08:02
@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 307316 run on aarch64-darwin 1

4 packages failed to build:
  • python311Packages.coffea
  • python311Packages.coffea.dist
  • python311Packages.dask-awkward
  • python311Packages.dask-awkward.dist
6 packages built:
  • python311Packages.mplhep
  • python311Packages.mplhep.dist
  • python311Packages.uproot
  • python311Packages.uproot.dist
  • python312Packages.uproot
  • python312Packages.uproot.dist

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 307316 run on x86_64-darwin 1

4 packages failed to build:
  • python311Packages.coffea
  • python311Packages.coffea.dist
  • python311Packages.dask-awkward
  • python311Packages.dask-awkward.dist
6 packages built:
  • python311Packages.mplhep
  • python311Packages.mplhep.dist
  • python311Packages.uproot
  • python311Packages.uproot.dist
  • python312Packages.uproot
  • python312Packages.uproot.dist

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 307316 run on x86_64-linux 1

2 packages failed to build:
  • python311Packages.coffea
  • python311Packages.coffea.dist
8 packages built:
  • python311Packages.dask-awkward
  • python311Packages.dask-awkward.dist
  • python311Packages.mplhep
  • python311Packages.mplhep.dist
  • python311Packages.uproot
  • python311Packages.uproot.dist
  • python312Packages.uproot
  • python312Packages.uproot.dist

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 307316 run on aarch64-linux 1

2 packages failed to build:
  • python311Packages.coffea
  • python311Packages.coffea.dist
8 packages built:
  • python311Packages.dask-awkward
  • python311Packages.dask-awkward.dist
  • python311Packages.mplhep
  • python311Packages.mplhep.dist
  • python311Packages.uproot
  • python311Packages.uproot.dist
  • python312Packages.uproot
  • python312Packages.uproot.dist

@GaetanLepage GaetanLepage changed the title python311Packages.uproot: 5.3.2 -> 5.3.3 python311Packages.uproot: 5.3.2 -> 5.3.4 May 6, 2024
@GaetanLepage GaetanLepage changed the title python311Packages.uproot: 5.3.2 -> 5.3.4 python311Packages.uproot: 5.3.2 -> 5.3.5 May 7, 2024
@veprbl
Copy link
Member

veprbl commented May 8, 2024

Result of nixpkgs-review pr 307316 run on x86_64-linux 1

4 packages failed to build:
  • python311Packages.coffea
  • python311Packages.coffea.dist
  • python312Packages.coffea
  • python312Packages.coffea.dist
12 packages built:
  • python311Packages.dask-awkward
  • python311Packages.dask-awkward.dist
  • python311Packages.mplhep
  • python311Packages.mplhep.dist
  • python311Packages.uproot
  • python311Packages.uproot.dist
  • python312Packages.dask-awkward
  • python312Packages.dask-awkward.dist
  • python312Packages.mplhep
  • python312Packages.mplhep.dist
  • python312Packages.uproot
  • python312Packages.uproot.dist

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 307316 run on x86_64-linux 1
4 packages failed to build:
12 packages built:

Two tests are still failing for coffea:

FAILED tests/test_lumi_tools.py::test_lumimask[https://raw.githubusercontent.com/CoffeaTeam/coffea/master/tests/samples/Cert_294927-306462_13TeV_EOY2017ReReco_Collisions1…
FAILED tests/test_lumi_tools.py::test_lumilist_dask - TypeError: ('Could not serialize object of type HighLevelGraph', '<ToPickle...

@GaetanLepage GaetanLepage force-pushed the uproot branch 2 times, most recently from 32b3b32 to 567589f Compare May 8, 2024 20:51
@veprbl
Copy link
Member

veprbl commented May 8, 2024

Bug report it to the upstream? There is already at least one issue with HLG serialization.

@GaetanLepage GaetanLepage changed the title python311Packages.uproot: 5.3.2 -> 5.3.5 python311Packages.uproot: 5.3.2 -> 5.3.6, python311Packages.coffea: 2024.4.1 -> 2024.5.0 May 8, 2024
@GaetanLepage GaetanLepage mentioned this pull request May 14, 2024
Open
@GaetanLepage GaetanLepage marked this pull request as ready for review May 14, 2024 10:20
@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 307316 run on aarch64-darwin 1

16 packages built:
  • python311Packages.coffea
  • python311Packages.coffea.dist
  • python311Packages.dask-awkward
  • python311Packages.dask-awkward.dist
  • python311Packages.mplhep
  • python311Packages.mplhep.dist
  • python311Packages.uproot
  • python311Packages.uproot.dist
  • python312Packages.coffea
  • python312Packages.coffea.dist
  • python312Packages.dask-awkward
  • python312Packages.dask-awkward.dist
  • python312Packages.mplhep
  • python312Packages.mplhep.dist
  • python312Packages.uproot
  • python312Packages.uproot.dist

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 307316 run on x86_64-darwin 1

16 packages built:
  • python311Packages.coffea
  • python311Packages.coffea.dist
  • python311Packages.dask-awkward
  • python311Packages.dask-awkward.dist
  • python311Packages.mplhep
  • python311Packages.mplhep.dist
  • python311Packages.uproot
  • python311Packages.uproot.dist
  • python312Packages.coffea
  • python312Packages.coffea.dist
  • python312Packages.dask-awkward
  • python312Packages.dask-awkward.dist
  • python312Packages.mplhep
  • python312Packages.mplhep.dist
  • python312Packages.uproot
  • python312Packages.uproot.dist

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 307316 run on x86_64-linux 1

16 packages built:
  • python311Packages.coffea
  • python311Packages.coffea.dist
  • python311Packages.dask-awkward
  • python311Packages.dask-awkward.dist
  • python311Packages.mplhep
  • python311Packages.mplhep.dist
  • python311Packages.uproot
  • python311Packages.uproot.dist
  • python312Packages.coffea
  • python312Packages.coffea.dist
  • python312Packages.dask-awkward
  • python312Packages.dask-awkward.dist
  • python312Packages.mplhep
  • python312Packages.mplhep.dist
  • python312Packages.uproot
  • python312Packages.uproot.dist

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 307316 run on aarch64-linux 1

16 packages built:
  • python311Packages.coffea
  • python311Packages.coffea.dist
  • python311Packages.dask-awkward
  • python311Packages.dask-awkward.dist
  • python311Packages.mplhep
  • python311Packages.mplhep.dist
  • python311Packages.uproot
  • python311Packages.uproot.dist
  • python312Packages.coffea
  • python312Packages.coffea.dist
  • python312Packages.dask-awkward
  • python312Packages.dask-awkward.dist
  • python312Packages.mplhep
  • python312Packages.mplhep.dist
  • python312Packages.uproot
  • python312Packages.uproot.dist

@GaetanLepage
Copy link
Contributor Author

@veprbl Everything build fines. Feel free to merge :)

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 307316 run on x86_64-linux 1

16 packages built:
  • python311Packages.coffea
  • python311Packages.coffea.dist
  • python311Packages.dask-awkward
  • python311Packages.dask-awkward.dist
  • python311Packages.mplhep
  • python311Packages.mplhep.dist
  • python311Packages.uproot
  • python311Packages.uproot.dist
  • python312Packages.coffea
  • python312Packages.coffea.dist
  • python312Packages.dask-awkward
  • python312Packages.dask-awkward.dist
  • python312Packages.mplhep
  • python312Packages.mplhep.dist
  • python312Packages.uproot
  • python312Packages.uproot.dist

@drupol drupol merged commit 3f1b452 into NixOS:master May 15, 2024
22 of 24 checks passed
@GaetanLepage GaetanLepage deleted the uproot branch May 15, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natsukium natsukium natsukium approved these changes

@veprbl veprbl Awaiting requested review from veprbl

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GaetanLepage @veprbl @natsukium @drupol