labwc-tweaks-gtk: wrapGAppsHook -> wrapGAppsHook3 #307841
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Infinidoge
requested review from
mkg20001,
jtojnar,
figsoda,
teto,
adisbladis,
mweinelt,
thoughtpolice,
K900,
NickCao,
SuperSandro2000,
ttuegel,
emilylange,
zowoq,
winterqt,
Mic92,
stigtsp,
zakame,
dasJ,
sternenseemann,
maralorn,
ncfavier,
infinisil,
RaitoBezarius,
Ma27 and
Ericson2314
as code owners
github-actions
bot
added
6.topic: nixos
github-actions
bot
added
8.has: changelog
8.has: module (update)
trofi
approved these changes
Apr 29, 2024
13 tasks
|
Oh jeez apparently I summoned the squad. |
|
anything in aliases.nix is deprecated and therefore made invisible in nixpkgs |
|
Ah, that makes sense! |
oh, yeah, you'll need to properly rebase as per contributing.md, not just change the target branch. locking due to mass ping |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
On staging,
labwc-tweaks-gtkfails to evaluate becausewrapGAppsHookwasn't found. I am unsure why the alias in top-level/aliases wasn't working, however setting this explicitly is worth while anyways.This should fix the eval error I ran into in #286267.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.