-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
haskell.compiler: port all make/native-bignum GHCs to common expr #308776
haskell.compiler: port all make/native-bignum GHCs to common expr #308776
Conversation
df81793
to
f3dc8c3
Compare
The common expression is a little messy to avoid rebuilds. It can be cleaned up in a second step. `9.4.8.fixme.nix` is used temporarily so that git's rename detection gets where common-make-native-bignum.nix is coming from. 8.10.7 keeps its expression since it uses integer-simple which changes the expression's interface. This is unfortunately very annoying to reflect in a common expression.
f3dc8c3
to
88d91dd
Compare
cc @AlexandreTunstall Hopefully with the file naming shenanigans I've done, it'll be easy to rebase changes onto this. Should make our lives a little easier… |
My workflow so far has been to It's a bit unfortunate that this still had to be done despite the deprecation of Make-based builds, but who knows how long Nixpkgs will continue to have these not-so-new versions of GHC. |
I still need to figure out how this can be made to work properly. Maybe we need to delay renaming |
b50ec8c
to
88d91dd
Compare
@AlexandreTunstall Indeed, without renaming the file right away, rebasing works fine, so I'll keep it like this until we've merged all outstanding GHC changes. |
This is a left over to do from NixOS#308776. Rebasing existing PR (prior to NixOS#308776) would need to be rebased on a change before the commit included in this PR.
The common expression is a little messy to avoid rebuilds. It can be cleaned up in a second step.
9.4.8.fixme.nix
is used temporarily so that git's rename detection gets where common-make-native-bignum.nix is coming from.8.10.7 keeps its expression since it uses integer-simple which changes the expression's interface. This is unfortunately very annoying to reflect in a common expression.
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.