Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ideamaker: init at 4.3.3 #309130

Merged
merged 2 commits into from
May 23, 2024
Merged

ideamaker: init at 4.3.3 #309130

merged 2 commits into from
May 23, 2024

Conversation

cjshearer
Copy link
Member

@cjshearer cjshearer commented May 4, 2024 •
edited
Loading

Description of changes

A slicer for 3D printers.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label May 4, 2024
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label May 4, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels May 5, 2024
@DontEatOreo
Copy link
Member

Adding yourself to the maintainers/maintainer-list.nix should be a separate commit

DontEatOreo
DontEatOreo suggested changes May 6, 2024
View reviewed changes
pkgs/applications/misc/ideamaker/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/ideamaker/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/ideamaker/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/ideamaker/default.nix Outdated Show resolved Hide resolved
@DontEatOreo
Copy link
Member

You can apply the formatting suggestions by running nix run nixpkgs#nixfmt-rfc-style -- pkgs/applications/misc/ideamaker/default.nix that way you will automatically comply with RFC 0166

@DontEatOreo
Copy link
Member

Result of nixpkgs-review pr 309130 run on x86_64-linux 1

@DontEatOreo
Copy link
Member

Despite the nixpkgs-review result I was able to successfully build and run ideamaker on x86_64-linux after allowing unsecure and unfree packages

@cjshearer
Copy link
Member Author

With NIXPKGS_ALLOW_INSECURE=1 NIXPKGS_ALLOW_UNFREE=1 I get:

Result of nixpkgs-review pr 309130 run on x86_64-linux 1

1 package built:
  • ideamaker

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label May 7, 2024
Pandapip1
Pandapip1 suggested changes May 13, 2024
View reviewed changes
Copy link
Contributor

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New packages should be in pkgs/by-name.

@cjshearer
Copy link
Member Author

cjshearer commented May 13, 2024 •
edited
Loading

https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#category-hierarchy

The category hierarchy may still be used for packages that should be imported using an alternate callPackage, such as python3Packages.callPackage or libsForQt5.callPackage.

This package uses libsForQt5.callPackage

Pandapip1
Pandapip1 approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM then.

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels May 13, 2024
@wegank wegank removed the 12.approvals: 2 This PR was reviewed and approved by two reputable people label May 23, 2024
Pandapip1
Pandapip1 approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM

@cjshearer
Copy link
Member Author

Sorry for push. I synced my fork and realized too late I was stupid and made this PR off my fork's master branch.

@cjshearer
Copy link
Member Author

@lovesegfault I know you previously maintained this package before it was marked broken and removed. Would you mind reviewing?

After some sleuthing about with gdb and ghidra, I learned the segfault was due to the application needing and old (like 8 years old) version of curl and openssl.

lovesegfault
lovesegfault requested changes May 23, 2024
View reviewed changes
Copy link
Member

@lovesegfault lovesegfault left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, I'd love to see an update script for this as well :)

Update script example: https://github.com/NixOS/nixpkgs/blob/master/pkgs/os-specific/darwin/raycast/default.nix#L40-L53

@cjshearer cjshearer requested a review from lovesegfault May 23, 2024 19:39
@lovesegfault lovesegfault merged commit 0e1767b into NixOS:master May 23, 2024
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DontEatOreo DontEatOreo DontEatOreo approved these changes

@Pandapip1 Pandapip1 Pandapip1 approved these changes

@lovesegfault lovesegfault lovesegfault approved these changes

Assignees
No one assigned
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cjshearer @DontEatOreo @lovesegfault @Pandapip1 @wegank @NixOSInfra