-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
git-butler: init at 0.11.7 #311361
git-butler: init at 0.11.7 #311361
Conversation
Result of 1 package blacklisted:
2 packages built:
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3927 |
As long as it works, I wouldn't object to merge this, but on the long term, it might be favorable to build from source, as tried in #289664 Given that the mentioned PR is open for a long time though, it might be a good short-term solution to package the AppImage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Title should be git-butler:...
Tested the package on x86-64 Linux, which works besides of some little UI bugs, which I believe to exist upstream as well. Will test the MacOS build once I get to my MacOS machine tonight
Result of 2 packages built:
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3974 |
940fe02
to
f19fc07
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4017 |
Since we already got a PR that builds it from source and with the recent addition of the pnpm builder, I don't see any blockers over there. Please pick that up instead and we can come back to this one, if that hits a wall. |
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.