Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

starship: 1.18.2 -> 1.19.0 #312004

Merged
merged 1 commit into from
May 16, 2024
Merged

starship: 1.18.2 -> 1.19.0 #312004

merged 1 commit into from
May 16, 2024

Conversation

davidkna
Copy link
Contributor

@davidkna davidkna commented May 15, 2024

Description of changes

changelog

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Misterio77
Copy link
Member

Result of nixpkgs-review pr 312004 run on x86_64-linux 1

1 package built:
  • starship

@donovanglover donovanglover added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label May 15, 2024
Copy link
Contributor

@booniepepper booniepepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built/ran for me as well

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels May 16, 2024
@marsam marsam merged commit 179e0f1 into NixOS:master May 16, 2024
32 checks passed
@davidkna davidkna deleted the starship-v1.19.0 branch May 16, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants